Skip to content

Update GPU profile types for PC sampling #6362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnurizen merged 1 commit into from
May 21, 2026
+19 −1
Merged

Update GPU profile types for PC sampling #6362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ui/packages/shared/profile/src/ProfileMetricsGraph/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,9 +368,15 @@ const ProfileMetricsGraph = ({
yAxisLabel = 'CPU Cores';
yAxisUnit = '';
}
if (sampleType === 'cuda') {
if (sampleType === 'cuda' || sampleType === 'gpu_time') {
yAxisLabel = 'GPU Time';
}
if (sampleType === 'gpu_kernel_time') {
yAxisLabel = 'GPU Kernel Time';
}
if (sampleType === 'gpu_stall_time') {
yAxisLabel = 'GPU Stall Time';
}
}
if (sampleUnit === 'bytes') {
yAxisLabel = 'Bytes per Second';
Expand Down
12 changes: 12 additions & 0 deletions ui/packages/shared/profile/src/ProfileTypeSelector/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,18 @@ export const wellKnownProfiles: WellKnownProfiles = {
name: 'On-GPU',
help: 'Time spent on the GPU.',
},
'parca_agent:gpu_time:nanoseconds:gpu_time:nanoseconds:delta': {
name: 'On-GPU',
help: 'Time spent on the GPU. Combines kernel execution time and PC stall samples; the gpu_view label distinguishes the two views.',
},
'parca_agent:gpu_kernel_time:nanoseconds:gpu_kernel_time:nanoseconds:delta': {
name: 'On-GPU',
Comment thread
metalmatze marked this conversation as resolved.
help: 'GPU kernel execution time measured via CUDA runtime callbacks.',
},
'parca_agent:gpu_stall_time:nanoseconds:gpu_stall_time:nanoseconds:delta': {
name: 'GPU Stalls',
help: 'GPU stall time accumulated from PC sampling — shows where threads were waiting on the GPU.',
},
};

export function flexibleWellKnownProfileMatching(name: string): WellKnownProfile | undefined {
Expand Down
Loading