Skip to content

Fix Steam/Epic game stop issue with improved status reporting and clear warnings#12

Merged
pardeike merged 3 commits intomainfrom
copilot/fix-bb111205-d10e-4894-b027-fc9b54394285
Sep 13, 2025
Merged

Fix Steam/Epic game stop issue with improved status reporting and clear warnings#12
pardeike merged 3 commits intomainfrom
copilot/fix-bb111205-d10e-4894-b027-fc9b54394285

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 13, 2025

Problem

GABS was providing misleading feedback when attempting to stop Steam/Epic games. The issue manifested as:

  • games_stop reported "success" even though only the launcher process was stopped
  • The actual game process continued running independently
  • AI assistants received false "stopped" status while games were still active
  • Users were confused about GABS capabilities and actual game state

This occurred because GABS only manages launcher processes for Steam/Epic games, not the actual game processes that run independently.

Solution

This PR implements comprehensive improvements to provide honest, transparent feedback about GABS limitations:

Enhanced Status Reporting

  • Clear status descriptions: "launched via SteamAppId (GABS cannot track the game process)" instead of vague "launched"
  • Differentiated statuses: Direct processes show "running (GABS controls the process)" while launcher games show tracking limitations
  • Informative explanations: Status checks include helpful notes about checking Steam/Epic for actual game state

Honest Stop Commands

  • Transparent warnings: Steam/Epic stop attempts now show "⚠️ launcher process stopped, but actual SteamAppId game may still be running independently"
  • Clear guidance: Provides specific instructions: "Please stop the game through SteamAppId or the game's own interface"
  • Not marked as errors: Warnings are informational, not failures, since this is expected behavior

Proactive User Education

  • Games list warnings: Shows "Note: GABS can start but cannot directly stop SteamAppId games" upfront
  • Consistent messaging: All tools provide clear explanations of GABS capabilities and limitations
  • Actionable instructions: Users know exactly what to do when GABS can't directly control games

Example

Before:

{"result": {"content": [{"text": "Game 'rimworld' stopped successfully"}]}}

Game actually still running - misleading!

After:

{
  "result": {
    "content": [{
      "text": "⚠️ launcher process stopped, but actual SteamAppId game may still be running independently. GABS cannot directly control SteamAppId-launched games. Please stop the game through SteamAppId or the game's own interface\n\nNote: For Steam/Epic games, GABS can only stop the launcher process, not the actual game."
    }]
  }
}

Clear, honest, actionable feedback!

Testing

  • ✅ All existing tests pass (no regressions)
  • ✅ Comprehensive new test suite validates the fix
  • ✅ DirectPath games maintain full start/stop/status functionality
  • ✅ Steam/Epic games provide clear, helpful feedback about limitations
  • ✅ Status reporting is accurate and informative across all game types

This change transforms GABS from providing misleading "success" messages to being completely transparent about its actual capabilities, ensuring AI assistants and users receive accurate information to make informed decisions.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits September 13, 2025 20:58
Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
…ar warnings

Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Copilot AI changed the title [WIP] starting apps works, but stopping seems not to work. I can ask the AI about if the app is started after I told it to stop it and it said that it was stopped (but it was still running) Fix Steam/Epic game stop issue with improved status reporting and clear warnings Sep 13, 2025
Copilot AI requested a review from pardeike September 13, 2025 21:04
@pardeike pardeike marked this pull request as ready for review September 13, 2025 21:04
@pardeike pardeike merged commit bcdc456 into main Sep 13, 2025
3 checks passed
@pardeike pardeike deleted the copilot/fix-bb111205-d10e-4894-b027-fc9b54394285 branch September 13, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants