Add optional process name configuration for improved game stopping#19
Merged
Add optional process name configuration for improved game stopping#19
Conversation
Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve stopping
Add optional process name configuration for improved game stopping
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the suboptimal game stopping mechanism by adding support for an optional
stopProcessNameconfiguration field that enables more reliable game termination, particularly for Steam/Epic launcher games.Problem
Previously, GABS could only stop the processes it directly launched. For Steam/Epic games, this meant only the launcher process could be stopped, not the actual game process that runs independently. This left games running even after calling
games.stoporgames.kill.Solution
Added an optional
stopProcessNamefield to game configurations that allows users to specify the actual process name to terminate:{ "rimworld": { "launchMode": "SteamAppId", "target": "294100", "stopProcessName": "RimWorldWin64.exe" }, "minecraft": { "launchMode": "DirectPath", "target": "/opt/minecraft/start.sh", "stopProcessName": "java" } }Implementation Details
taskliston Windows,pson macOS/Linuxgames.stop(graceful) andgames.kill(force)Platform Support
tasklist /FO CSVtaskkill [/F] /PIDps axo pid,commkill [-9] <pid>ps axo pid,commkill [-9] <pid>The implementation handles platform-specific executable naming (e.g., adding
.exeon Windows) and supports both exact matches and partial name matching for flexibility.Fixes #18.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.