Conversation
Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] You can improve the 'GABS cannot track whether it's still running' part. Since we now have guarantees that we either have a binary path or a process name, we can actually track the status. Find all occurances of similar output or behaviour and fix them.
Improve process tracking for Steam/Epic games with stopProcessName configuration
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GABS previously showed "cannot track whether it's still running" messages for all Steam/Epic launcher-based games, even when sufficient information was available to actually track the game processes. This created a poor user experience and inaccurate status reporting.
The core issue was that the
IsRunning()method in the process controller always returnedfalsefor Steam/Epic games, regardless of whether astopProcessNamewas configured that would enable actual process tracking.Solution
Enhanced the process tracking system to leverage available tracking information:
1. Improved
IsRunning()MethodThe process controller now uses
stopProcessNamewhen available to check if Steam/Epic games are actually running:2. Enhanced Status Reporting
Status messages now accurately reflect tracking capabilities:
"running (GABS is tracking the game process)""launched via SteamAppId (GABS cannot track the game process - no stopProcessName configured)""running (GABS controls the process)"(unchanged)3. Intelligent Warning Messages
The "cannot track" warning now only appears when genuinely no tracking information is available, and includes helpful configuration guidance.
Testing
Added comprehensive test coverage including:
stopProcessNameshow accurate statusstopProcessNamestill show appropriate warningsBackward Compatibility
All changes are additive and backward compatible:
This addresses the core issue: "Since we now have guarantees that we either have a binary path or a process name, we can actually track the status" - GABS now does exactly this.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.