Remove unnecessary timestamped bridge filenames and fix concurrency for different games#35
Merged
Remove unnecessary timestamped bridge filenames and fix concurrency for different games#35
Conversation
Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Verify concurrency fix
Remove unnecessary timestamped bridge filenames and fix concurrency for different games
Sep 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the concurrency concerns raised in issue #34 by fixing the fundamental misunderstanding about what type of concurrency should be supported.
Problem
The original code was designed to handle concurrent launches of the same game using timestamped filenames like
bridge-{timestamp}.json. However, the actual requirement was to support concurrent launches of different games (e.g., game X and game Y simultaneously). The concern was that ENV variables might not be properly isolated between processes, potentially causing cross-contamination.Solution
1. Removed Unnecessary Timestamped Filenames
Before:
After:
2. Verified ENV Variable Isolation
Added comprehensive tests to verify that Go's
exec.Commandprovides proper environment variable isolation:3. Updated Concurrency Tests
Changed the concurrency test from testing multiple launches of the same game to testing concurrent launches of different games, which is the actual supported use case:
Key Findings
exec.Command- each process gets its own environmentbridge.jsonin its own directoryTest Results
The code now properly supports concurrent launching of different games while removing unnecessary complexity that was designed for an unsupported use case.
Fixes #34.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.