Skip to content

Make startup timeout configurable and raise default to 60s#64

Merged
pardeike merged 1 commit intomainfrom
copilot/fix-gabs-disconnection-issue
Apr 11, 2026
Merged

Make startup timeout configurable and raise default to 60s#64
pardeike merged 1 commit intomainfrom
copilot/fix-gabs-disconnection-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 10, 2026

Summary

  • add a new timeouts.startup config section in ~/.gabs/config.json
  • wire configurable startup timeouts into the serialized starter
  • raise the default GABP startup wait from 10s to 60s
  • keep NewServerForTesting short test timeouts unless a timeout override is explicitly configured
  • update docs and example config

Validation

  • go test ./...
  • go build ./cmd/gabs
  • parallel_validation (Code Review + CodeQL)

Notes

I also reviewed other hardcoded timeout-related values already in the repo. The remaining notable ones are separate behaviors and were left unchanged in this PR, including:

  • games.connect default timeout: 15s
  • mirrored tool sync / call defaults: 30s
  • process stop grace period: 3s
  • HTTP shutdown timeout: 10s
  • attention refresh timeout: 2s
  • a few polling/backoff intervals in process/GABP internals

Agent-Logs-Url: https://github.com/pardeike/GABS/sessions/41a589b5-0814-49b5-adc6-28d91c066b78

Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Copilot AI requested a review from pardeike April 10, 2026 23:06
@pardeike pardeike marked this pull request as ready for review April 11, 2026 00:17
@pardeike pardeike merged commit de05d04 into main Apr 11, 2026
5 checks passed
@pardeike pardeike deleted the copilot/fix-gabs-disconnection-issue branch April 11, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants