refactor(cli): drop setPop command and use personhood precompile#133
Merged
Conversation
Adds a `--env` / `--network` selector that lets the CLI target multiple DotNS deployments, with per-environment RPC and contract addresses. Native token decimals and symbol are read from chain spec metadata instead of being hard-coded. * Adds `resolveDotnsEnvironment` and `getChainTokenInfo` * Threads env into auth options, lookup, info, and context * Adds per-env entries in `CONTRACTS` and shared constants * Mirrors the env mapping in the UI network store * Surfaces `--env` in deploy and bulletin GitHub Actions
Personhood status is no longer mutable from the CLI; the precompile is now the source of truth for reads. This PR removes the `dotns pop set` command, the `--status` flag on `dotns register`, and the helper plumbing that supported them. `getUserProofOfPersonhoodStatus` now calls the personhood precompile via the env-aware constants added in the previous PR, and `finalizeRegularRegistration` threads native token decimals through. Depends on the multi-environment PR.
CI Summary
Benchmark UI - Passed (258s)
Labelspkg: cli, type: test, dependencies, pkg: ui |
3 tasks
andrew-ifrita
pushed a commit
that referenced
this pull request
May 13, 2026
## Summary - Refreshes `StoreFactory.json` for the redesigned factory (split into protocol-managed `LabelStore` and user-claimed `UserStore`). - Removes `displayDeployedStore` and `ensureStoreAuthorizations`, both of which called selectors that no longer exist on chain and were misreported as "origin not mapped" failures. - Adds `claimUserStoreIfNeeded`, which reads `getUserStore` and claims one for the signer if absent. The two prior register stages collapse into a single "Claiming user store" step. ## Test plan - [ ] `bun run --cwd packages/cli test tests/integration/register/register.test.ts` - [ ] `dotns register domain --name <new>` shows the claimed user store address - [ ] Re-running `dotns register domain` for the same account does not re-claim ## Order Third in the stack. Base is `spha/cli-remove-setpop` (#133). The `dotns store` subcommand still uses the old single-store API and is out of scope here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotns pop set, the--statusflag ondotns register, and the helpers that supported them.getUserProofOfPersonhoodStatusnow calls the personhood precompile via the env-aware constants from PR feat(cli): multi-environment support #132.finalizeRegularRegistrationthreads native token decimals through.Test plan
bun run --cwd packages/cli test tests/unit/popdotns register domain --name <new>succeeds without--statusdotns pop info --key-uri //Alicereads from the precompileOrder
Second in the stack. Base is
spha/cli-multi-env(#132). Merge after PR #132 lands so the precompile constants resolve cleanly.