feat: Use CAR only in transit#43
Conversation
CI Summary
Labelspkg: cli, scope: bulletin |
|
Did you change anything in the build so the CID is different? |
Yes. I added a bunch of photos to up the size from 2-3MB to 20+MB and change the root CID in the process edit: old CID for easy reference: https://bafybeictaikgnxa6aiumef2rfheygvdz2dgmh7sb6f7dumkizodzqdgbua.ipfs.dweb.link/ |
|
Why are you storing the blocks individually? The whole point of using CAR is to avoid that altogether |
This reverts commit 5fdf89e. Batching is not supported by Bulletin Chain
|
I attempted to batch blocks together in 5fdf89e which took us from 99 transactions to 4. However, Bulletin Chain doesn't currently support batching so that approach is dead on arrival. |
To keep with IPFS standards and interoperability and reduce friction for end users. This is meant to be a foundational piece of the platform. Moving away from established standards here will only have compounding effects for everyone building on the platform. But also looking at this, by sending the blocks individually we just added a useless intermediate step. I will close this MR. If a user wants to upload a car directly, they can do it with the existing functionality after first generating the CAR and then uploading that blob. We shouldn't help the user shoot themselves in the foot by uploading a CAR blob in a way that goes against standard IPFS usage and practices. |
Changes built off of #36 to demonstrate what was being discussed.
This works