Skip to content

[BUG] Up-front phone approval count not shown for --signer phone #266

@ottovlotto

Description

@ottovlotto

Severity: Missing spec requirements (P1)
Reported by: DevEx Audit External
Source: DevEx Audit (External), 3 June 2026

Symptom

Up-front phone approval count not shown
Severity: Missing spec requirements
Spec reference: CLAUDE.md › "Up-front phone approval count: before the first signing prompt, print 'This will need 3 approvals on your phone — keep it ready.'"

When using --signer phone, there is no pre-flight announcement of how many phone approvals to expect before the first signing prompt fires. The phone signer does show inline step-by-step prompts (📱 Approve on your phone: DotNS step (1/1)) during execution, but no upfront count.
For dev signer, No phone approvals required. is correctly shown in the summary block - the gap is the phone signer path only.

Reproduction

DOT_DEPLOY_VERBOSE=1 DOT_MEMORY_TRACE=1 playground deploy --signer phone --domain mytest --playground 2> >(tee dot.log >&2)

Observe summary block does NOT print "This will need N approvals on your phone — keep it ready." before the first signing step.

Recommended fix / next steps

  • Compute the expected number of phone approvals during preflight (DotNS register, deploy contract, etc.).
  • Print the up-front count message before the first signing prompt fires.
  • Mirror the existing "No phone approvals required." line that dev signer already shows.
  • Spec reference: CLAUDE.md › "Up-front phone approval count".

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1Defer to V1.x — not blocking V1 shipbugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions