fix(e2e): rename E2E domains to NoStatus-compatible labels#171
Merged
Conversation
All 9 E2E_DOMAINS had 6-char bases, classifying as PopLite under classifyLabel(). On paseo-next-v2 setUserPopStatus is owner-gated, so a NoStatus deployer cannot self-attest — every deploy cell was failing at the DotNS registration phase. Rename all labels to use ≥9-char bases + exactly 2 trailing digits, which classifies as NoStatus (no PoP required) on any environment. Also update a stale comment in availability.ts that described PoP-gated names as "still registrable on testnet" — they are not on paseo-next-v2 when the signer is NoStatus. Fixes #169, #170.
Contributor
|
Dev build ready — try this branch: |
Since b228817 (feat: migrate to paseo-next-v2), dot mod uses getReadOnlyRegistryContract and never calls resolveSigner. The --suri flag is a deprecated no-op. The test "exits non-zero with signer suggestion when no signer available" was asserting on "No signer available" output that no longer exists. Update the test to reflect the actual signer-less behavior: dot mod proceeds directly to the registry lookup, and an unknown domain produces "not found in registry" (not a signer error).
1 task
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
getChainConfig() error message says 'Use --env paseo-next-v2' not 'Use --env testnet'. The old assertion was written against an earlier wording and was masked by the DotNS PopLite failures in the same cell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Fixes #169, #170.