fix(init): skip sudo as root, install git before foundry, fix cold-start log capture#173
Merged
Merged
Conversation
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolchain.ts: addedsudo()helper that emits"sudo "when process is not running as root and""when it is (bare Ubuntu containers run as root withoutsudoinstalled). Applies to the IPFS install and git install steps.toolchain.ts: moved git install step before foundry step —foundryup-polkadotclones repos viagit, so git must be present before foundry runs..github/workflows/e2e.yml: rewrote theInit cold-start smoke teststep sotee /tmp/cold-start.logruns on the runner host (outside docker), fixing the "No such file or directory" error. Injectedsudo gitinto the container'sapt-getpreflight so thesudo()guard hassudoavailable on non-root systems.Test plan
pr-installcell — runs the cold-start test against the checked-in binary