Fix RFC10 allowance init handling#186
Merged
Merged
Conversation
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
4 tasks
…ce-init # Conflicts: # src/commands/init/IdentityLines.tsx # src/commands/init/identityLine.test.ts # src/commands/init/identityLine.ts # src/utils/auth.ts # src/utils/sessionSigner.ts
…ce-init # Conflicts: # src/commands/init/AccountSetup.tsx # src/utils/allowances/bulletin.test.ts # src/utils/allowances/bulletin.ts # src/utils/allowances/slotKeys.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BulletInAllowancefrom thedot initmobile resource-allocation requestBulletin authorization neededwarning with the env-configured faucet URL and account to authorizedot logoutcan still recover when an old stored session is missingrootAccountIdMain Merge Reconciliation
This branch is merged with current
mainthrough #188 and #189.Kept from #188:
logged inshows the SSO root addressproduct accountshows the derived product SS58 and matching H160identityLine.tshelper stays deletedKept from #189:
QrLoginno longer calls parent state updates from inside asetStatusupdaterbulletinAuthorizationUrlstoreSlotAccountKeysFromOutcomesuses one batched read-modify-write and preserves sibling slot keysIntentionally changed from #189:
BulletInAllowanceis not requested from mobile duringdot initUser-Visible Behavior
When the cached Bulletin slot account has no usable Bulletin authorization,
dot initcompletes setup and prints:The allowances row is no longer failed solely because Bulletin authorization is missing.
Verification
pnpm format:checkpnpm lint:licensepnpm testpnpm build