feat: record source domain when modding an app#205
Merged
Conversation
`dot mod` writes the source app's domain into `dot.json::moddedFrom`, and `dot deploy --playground` reads it back and publishes it as the `moddedFrom` field in the on-chain metadata JSON — enabling "Modded from: <domain>" attribution in the playground-app. The value is shape-validated via `normalizeDomain` at read time so a hand-edited `dot.json` can't push unsafe strings into shared metadata.
Contributor
|
Dev build ready — try this branch: |
Contributor
E2E Test Pass · ✅ PASSTag:
Sentry traces: view spans for this run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dot modwrites the source app's domain intodot.json::moddedFrom, anddot deploy --playgroundreads it back and publishes it as themoddedFromfield in the on-chain metadata JSON — enabling "Modded from: " attribution in the playground-app. The value is shape-validated vianormalizeDomainat read time so a hand-editeddot.jsoncan't push unsafe strings into shared metadata.