Skip to content

Standardised all cases to have the same case#86

Merged
Bullrich merged 1 commit intomainfrom
standarising-cases
Sep 21, 2023
Merged

Standardised all cases to have the same case#86
Bullrich merged 1 commit intomainfrom
standarising-cases

Conversation

@Bullrich
Copy link
Copy Markdown
Contributor

Standardised all cases to have the same case.

Renamed all cases of min_approvals to minApprovals

@Bullrich Bullrich requested a review from mordamax September 21, 2023 13:17
@Bullrich Bullrich requested a review from a team as a code owner September 21, 2023 13:17
@Bullrich Bullrich self-assigned this Sep 21, 2023
@Bullrich Bullrich merged commit d6a513f into main Sep 21, 2023
@Bullrich Bullrich deleted the standarising-cases branch September 21, 2023 13:28
Bullrich added a commit to paritytech/polkadot-sdk that referenced this pull request Oct 3, 2023
Renamed `min_approvals` to `minApprovals`. A breaking change in paritytech/review-bot#86 which was done to standarize all the cases (so now everything is camelCase)
Bullrich added a commit to paritytech/polkadot-sdk that referenced this pull request Oct 4, 2023
## [Updated review bot
version](677610b)

updated version to version `2.0.1` which contains
paritytech/review-bot#90, a fix for the team
members not being fetch in its totality.

## [Updated review-bot.yml minApprovals
convention](b144683)

Renamed `min_approvals` to `minApprovals`. A breaking change in
paritytech/review-bot#86 which was done to
standarize all the cases (so now everything is camelCase)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants