Skip to content

Generate nightly builds and json files#357

Merged
alvicsam merged 28 commits intomainfrom
as-nightly-json
Jul 7, 2025
Merged

Generate nightly builds and json files#357
alvicsam merged 28 commits intomainfrom
as-nightly-json

Conversation

@alvicsam
Copy link
Copy Markdown
Contributor

@alvicsam alvicsam commented Jul 3, 2025

PR adds a nightly release pipeline.
Since the logic for the nightly build and release differs significantly from the usual pipeline, I decided to put it in a separate file. The same applies to the Python script that generates JSON files.

The nightly pipeline runs at 01:00 UTC every day, producing artefacts and retaining them for 40 days if commits are made the day before it runs.

cc #355
cc https://github.com/paritytech/devops/issues/4141

@alvicsam alvicsam marked this pull request as ready for review July 7, 2025 12:07
@alvicsam alvicsam changed the title [WIP] Generate nightly builds and json files Generate nightly builds and json files Jul 7, 2025
@alvicsam alvicsam requested a review from AndWeHaveAPlan July 7, 2025 12:10
@alvicsam alvicsam mentioned this pull request Jul 7, 2025
Copy link
Copy Markdown
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alvicsam!


env:
CARGO_TERM_COLOR: always
# if changed, dont forget to update the env var in release-nightly.yml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory the nightly release should just have different commit inputs right? Then no actual build logic needs to be duplicated. I see a lot of duplicated code in release-nightly.yml - for maintainability I'd appreciate making release.yml more modular (maybe as it's own GH actions or even a couple ones). WDYT?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory the nightly release should just have different commit inputs right?

In theory, yes, and the build jobs are the same, but the logic for working with artifacts differs. I tried to keep everything in one pipeline. However, there were too many rules about whether a job or step should run, which made the pipeline definition difficult to read.

We could merge this one so it starts producing nightly builds and do the refactor later. WDYT?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the rules could be modularized too?

I am fine with merging it to simplify trying it out - if you promise to improve it afterwards :)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK no, it's not applicable to the rules. I'll create a separate issue then for the refactor.

@alvicsam alvicsam merged commit 7c932f7 into main Jul 7, 2025
14 checks passed
@alvicsam alvicsam deleted the as-nightly-json branch July 7, 2025 15:47
alvicsam added a commit that referenced this pull request Jul 8, 2025
dev-ethan556 added a commit to dev-ethan556/revive that referenced this pull request Sep 29, 2025
blaze-smith-op590 added a commit to blaze-smith-op590/revive that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants