Fix bug when fetching genesis block#83
Merged
joepetrowski merged 3 commits intomasterfrom Jun 14, 2020
Merged
Conversation
danforbes
force-pushed
the
fix/block/genesis
branch
2 times, most recently
from
f009ca9 to
95c71d8
Compare
Collaborator
joepetrowski
left a comment
joepetrowski
left a comment
There was a problem hiding this comment.
This majorly breaks the API for people looking for certain fields. Should we return empty objects for the extra fields? I could see some chains having an onInitialize/onFinalize genesis too.
emostov
reviewed
Jun 13, 2020
Contributor
emostov
left a comment
emostov
left a comment
There was a problem hiding this comment.
I think Joe has a fair point that warrants further discussion. Code looks good though!
danforbes
force-pushed
the
fix/block/genesis
branch
from
95c71d8 to
13f86c9
Compare
Contributor
Author
|
Yep, @joepetrowski is definitely right. I've addressed this issue. |
joepetrowski
approved these changes
Jun 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #82