Conversation
danforbes
approved these changes
Jun 14, 2020
Contributor
danforbes
left a comment
danforbes
left a comment
There was a problem hiding this comment.
I went through an ad hoc offline review with Joe to go over some nitpicks I had.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
numSlashingSpansto staking endpoint for use inwithdrawUnbonded.I added only a
numSlashingSpans: intto the output to reduce the risk of breaking the API. If we learn thatSlashingSpansis useful for users then we can add that without breaking this, but from what I can tell so far, this struct is only used for Offchain Phragmen and calculatingnumSlashingSpans.In fact, if
SlashingSpansis useful to people, I would suggest a whole new endpoint for it while leavingnumSlashingSpanshere. The purpose of theSTAKINGendpoint is to get relevant info about a staked account to prepare for calls likeunbond,bondExtra,withdrawUnbonded. It should not turn into a junk drawer for staking information.