export module error for downstream usage#246
Merged
ascjones merged 1 commit intoparitytech:masterfrom Mar 15, 2021
Merged
Conversation
Contributor
|
CI error with missing docs for these |
gregdhill
force-pushed
the
export-module-error
branch
2 times, most recently
from
980c71c to
cfaf708
Compare
Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
ascjones
approved these changes
Mar 12, 2021
Contributor
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
LGTM.
P.S. preferably add commits instead of force pushing to make the changes easier to see.
Contributor
Author
Noted, I thought it would be okay for this PR since there were not many changes but I will adopt your strategy going forward. |
Contributor
|
Yes no problem for this PR at all just noting it here |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill gregorydhill@outlook.com