Merged
Conversation
PierreBesson
force-pushed
the
balance-transfers
branch
5 times, most recently
from
d045ee7 to
4a33b14
Compare
… of relying on WS_ENDPOINT
PierreBesson
force-pushed
the
balance-transfers
branch
from
d4a4dd4 to
eda61eb
Compare
BulatSaif
approved these changes
May 10, 2023
| } | ||
| ) | ||
| # If the batch contains only 1 element, don't use batch | ||
| if len(batch_call) == 1: |
There was a problem hiding this comment.
it is better to keep batch or non-batch if the condition on the calling side since events/errors returned by batch and just call are different.
Contributor
Author
There was a problem hiding this comment.
I introduced this because in teleport_funds you had put this logic. So I simply moved it to substrate_batchall_call. Since we are wrapping transfer/teleport calls with this batch method, I think it's better to remove the batch when there is only 1 operation.
Co-authored-by: Bulat Saifullin <bulat@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also automatically adds the right number of decimals per UNIT.
Remark: docker tests are broken but the issue is also affecting the main branch.