Conversation
…ect safe area insets
- Update error handling in StreamingQuery
… position during streaming
…l/lymo into refactor/simplify-fetch
…nSeconds` in metadata flow
…l/lymo into refactor/simplify-fetch
…createStreamChannel` util function
…stCreate` to `onStoryRequestCreate`
…tching stories and tracks
…ndStoryQuery` with `useStoryQuery` and `useProcessLyrics`
…seTypingAnimation` hook for typing animation
…for fetching story data and improve query parameters handling
Refactor/simplify fetch
Contributor
There was a problem hiding this comment.
Pull request overview
This is a significant refactoring PR titled "dev" that transitions the codebase from an older architecture to a new structure. The changes include removing old flows and tools, introducing a new schema structure, updating Firebase configuration, and reorganizing the functions codebase.
Key changes include:
- Removal of build tooling (tsup) in favor of direct TypeScript compilation for the schemas package
- Introduction of new Firestore rules and updated Firebase configuration with emulator settings
- Major dependency updates including firebase-functions (v6→v7), genkit (v1.22→v1.24), and various React Native Firebase packages
- Refactoring of the functions architecture from old flow-based structure to new feature-based organization
Reviewed changes
Copilot reviewed 168 out of 174 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
scripts/predeploy.js |
Removed old predeploy script that handled schema packaging |
scripts/postdeploy.js |
Removed old postdeploy cleanup script |
patches/@genkit-ai+ai+1.24.0.patch |
Added patch for genkit type definitions to fix generic typing |
packages/schemas/tsup.config.ts |
Removed tsup build configuration |
packages/schemas/src/**/*.ts |
Removed old schema structure files |
packages/schemas/src/shared.ts |
Added new simplified shared schema definitions |
packages/schemas/src/functions.ts |
Added new function schemas for retrieveTrack |
packages/schemas/src/error.ts |
Added new error code definitions |
packages/schemas/src/doc.ts |
Added new document schemas for tracks, stories, and requests |
packages/schemas/package.json |
Simplified to export raw TypeScript instead of built files |
package.json |
Updated scripts and dependencies, added patch-package |
package-lock.json |
Massive dependency tree updates |
firestore.rules |
Added new Firestore security rules |
firebase.json |
Updated with new emulator config and simplified predeploy |
eslint.config.js |
Added path configuration for imports |
apps/functions/tsconfig.json |
Updated paths for new schema structure |
| Various helper/util files | Removed old implementation files |
apps/functions/src/index.ts |
Updated exports to new feature structure |
apps/functions/src/handlebars.d.ts |
Added type definitions for handlebars |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.