Add SCSS token output to build pipeline#6
Merged
Conversation
Generates dist/web/_lotus-tokens.scss from tokens.json alongside the existing CSS, Swift, and Android outputs. This file replaces the hand-maintained _colorPrimitives.scss in justpark-ui — it is the concrete step that lets parkhub/frontend consume Lotus token values and names from a generated source rather than keeping them in sync manually. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
dist/web/_lotus-tokens.scssas a generated output frombuild-platforms.mjs, alongside the existing CSS, Swift, and Android files.Why
justpark-uicurrently hand-maintains_colorPrimitives.scss— a static SCSS file that duplicates the values inDESIGN.md. This means token changes require a manual update in two places, and the values have already drifted (e.g.grey-500is different between the two files).This generated SCSS file is the concrete step that allows
parkhub/frontendto consume Lotus token values and names from a single automated source, rather than keeping them in sync by hand.Output
_lotus-tokens.scsscontains four sections, all derived directly fromtokens.json:$grey-500,$green-500etc.$text-primary,$action-primaryetc.$spacing-xs,$spacing-setc.$rounded-sm,$rounded-mdetc.$typography-h1-font-sizeetc.Variable names match
DESIGN.mdtoken names exactly — the same names used in the Swift and Android outputs — establishing shared language across all three platforms.Migration path (next step, separate PR in parkhub/frontend)
Once
@justpark/lotusis published,justpark-ui/_colors.scssswaps:Test plan
node scripts/build-platforms.mjsruns without errorsdist/web/_lotus-tokens.scssgenerated with correct values