Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 30, 2025

Pull Request

Issue

Closes: #1061

Approach

Bumps flutter_lints from 4.0.0 to 6.0.0. The new version introduces stricter linting rules that require explicit type annotations.

Fixes:

  • parse_notification.dart: Add String type to title parameter
  • parse_push.dart: Add explicit dynamic type to firebaseMessaging and message parameters (intentionally dynamic to avoid hard dependency on firebase_messaging)
  • parse_push.dart: Fix doc comment <List<String>>`List<String>` to avoid HTML parsing issues

Tasks

  • Add changes to documentation (guides, repository pages, code comments)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai
Copy link

coderabbitai bot commented Nov 30, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

… compatibility

Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 30, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/flutter_infra_release/releases/stable/linux/flutter_linux_3.32.1-stable.tar.xz
    • Triggering command: /usr/bin/curl curl -L -o flutter_sdk.tar.xz REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update flutter_lints from 4.0.0 to 6.0.0 feat: Bump flutter_lints from 4.0.0 to 6.0.0 in /packages/flutter Nov 30, 2025
Copilot AI requested a review from mtrezza November 30, 2025 11:52
Copilot finished work on behalf of mtrezza November 30, 2025 11:52
@mtrezza mtrezza marked this pull request as ready for review November 30, 2025 13:25
@mtrezza mtrezza merged commit 605d6e8 into dependabot/pub/packages/flutter/flutter_lints-6.0.0 Nov 30, 2025
11 checks passed
@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dependabot/pub/packages/flutter/flutter_lints-6.0.0@00d602d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...utter/lib/src/notification/parse_notification.dart 0.00% 1 Missing ⚠️
packages/flutter/lib/src/push/parse_push.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                   @@
##             dependabot/pub/packages/flutter/flutter_lints-6.0.0    #1084   +/-   ##
======================================================================================
  Coverage                                                       ?   43.46%           
======================================================================================
  Files                                                          ?       61           
  Lines                                                          ?     3587           
  Branches                                                       ?        0           
======================================================================================
  Hits                                                           ?     1559           
  Misses                                                         ?     2028           
  Partials                                                       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants