-
-
Notifications
You must be signed in to change notification settings - Fork 213
fix: ParseGeoPoint longitude validation checks wrong variable
#1089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
|
🚀 Thanks for opening this pull request! |
ParseGeoPoint longitude validation checks wrong variable
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1089 +/- ##
==========================================
+ Coverage 43.40% 43.51% +0.11%
==========================================
Files 61 61
Lines 3587 3587
==========================================
+ Hits 1557 1561 +4
+ Misses 2030 2026 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# [dart-v9.4.1](dart-9.4.0...dart-9.4.1) (2025-11-30) ### Bug Fixes * `ParseGeoPoint` longitude validation checks wrong variable ([#1089](#1089)) ([6b9ef6b](6b9ef6b))
|
🎉 This change has been released in version dart-v9.4.1 |
Pull Request
Issue
Closes: #1007
Approach
ParseGeoPointlongitude validation was checkinglatitudeinstead oflongitude, allowing invalid coordinates like(0.0, 200.0)to pass while incorrectly rejecting valid latitudes in range [90, 180).Fix:
latitudetolongitudein the two longitude bound assertionsTasks
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl-ssl.google.com/usr/bin/wget wget -qO- REDACTED(dns block)esm.ubuntu.com/usr/lib/apt/methods/https /usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.