fix: LiveQuery not working due to ethernet not recognized as connectivity state #1091

kirkmorrow · 2025-12-02T15:46:11Z

Part 2 of 2 fixes to address issue #1042
PR for part 1 is #1090

Pull Request

Link this pull request to an LiveQuery not working since 9.0.0.

Issue

Closes: #1042

This is part 2 of 2 required for this fix. The Dart package update will need to be committed first. Then this PR will need to update pubspec.yaml to use that new package before this can be merged.

Approach

Use new ethernet enum to return a connection type consistent with connectivity_plus.

Tasks

[ No] Add tests
- Not much to test here
[No ] Add changes to documentation (guides, repository pages, code comments)
- No existing documentation to update, changes are consistent with existing code

Summary by CodeRabbit

New Features
- Connectivity detection now uses a deterministic priority: Wi‑Fi > Ethernet > Mobile > None for both checks and live updates.
Tests
- Added comprehensive tests with a mock connectivity provider to validate mapping, priority order, and edge cases.
Chores
- Updated SDK dependency constraint and added a connectivity-related dev dependency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Part 2 of 2 fixes to address issue parse-community#1042

parse-github-assistant · 2025-12-02T15:46:15Z

🚀 Thanks for opening this pull request!

coderabbitai · 2025-12-02T15:46:21Z

📝 Walkthrough

Walkthrough

Centralizes connectivity interpretation in a new helper _mapConnectivity(List<ConnectivityResult>), updates checkConnectivity() and connectivityStream to use it, bumps Flutter package constraints/dev-dependencies, and adds tests with a mock ConnectivityPlatform verifying mapping and stream behavior.

Changes

Cohort / File(s)	Summary
Core Connectivity Implementation `packages/flutter/lib/parse_server_sdk_flutter.dart`	Adds private helper `_mapConnectivity(List<ConnectivityResult>)` and updates `checkConnectivity()` and `connectivityStream` to delegate to it. Priority: wifi > ethernet > mobile > none; ethernet counted as online when wifi absent.
Dependencies `packages/flutter/pubspec.yaml`	Bumps `parse_server_sdk` constraint to `>=9.4.2 <10.0.0` and adds dev-dependency `connectivity_plus_platform_interface: ^2.0.0`.
Connectivity Tests `packages/flutter/test/parse_connectivity_implementation_test.dart`	Adds `MockConnectivityPlatform` and tests for `Parse().checkConnectivity()` and `Parse().connectivityStream`, covering wifi, ethernet, mobile, none and priority rules (wifi > ethernet, ethernet > mobile).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Verify _mapConnectivity implements priority rules and ethernet-as-online behavior consistently with Windows/macOS edge cases.
Check tests correctly replace ConnectivityPlatform.instance, manage stream lifecycle (broadcast/close), and cover mixed-list inputs.
Confirm pubspec dependency bump and added dev-dependency do not conflict with existing constraints.

Possibly related PRs

fix: Ethernet not recognized as connectivity state #1090 — Related connectivity enum/value changes used by the new mapping/tests.

Suggested reviewers

mtrezza

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: fixing LiveQuery connectivity by recognizing ethernet as a valid connection state.
Description check	✅ Passed	The description properly links to the related issue #1042, explains this is part 2 of a fix, describes the approach, and addresses the template tasks.
Linked Issues check	✅ Passed	The PR implements the core fix from issue #1042 by treating ethernet as an online connection, ensuring LiveQuery receives correct connectivity state on Windows/macOS.
Out of Scope Changes check	✅ Passed	All changes directly address the linked issue: refactoring connectivity logic into a helper, updating dependency constraints, and adding tests for the new behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f57af7b and e8fe2d3.

📒 Files selected for processing (1)

packages/flutter/test/parse_connectivity_implementation_test.dart (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/flutter/test/parse_connectivity_implementation_test.dart

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

GitHub Check: Test Flutter 3.38, Windows
GitHub Check: Test Flutter 3.38, Ubuntu
GitHub Check: Test Flutter 3.38, macOS
GitHub Check: Test Flutter beta

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR adds support for the ethernet connectivity type to align with the connectivity_plus package, completing the fix for LiveQuery connectivity issues (issue #1042). This is part 2 of a two-part change that requires the Dart package update (PR #1090) to be merged first.

Key Changes:

Added ethernet connectivity checks to both checkConnectivity() and connectivityStream methods
Ethernet is prioritized between wifi and mobile in the connectivity type hierarchy

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

parse-github-assistant · 2025-12-02T18:32:42Z

The label type:bug cannot be used here.

codecov · 2025-12-02T18:37:28Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.75%. Comparing base (f76fde4) to head (e8fe2d3).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
+ Coverage   43.54%   43.75%   +0.21%     
==========================================
  Files          61       61              
  Lines        3587     3588       +1     
==========================================
+ Hits         1562     1570       +8     
+ Misses       2025     2018       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mtrezza · 2025-12-02T18:38:20Z

@kirkmorrow Does the PR title make sense?

kirkmorrow · 2025-12-02T18:47:00Z

@mtrezza This is part 2 of the fix. Feel free to update the title, I just stole the title text from the original bug this addresses.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mtrezza

Is this ready for merge?

kirkmorrow · 2025-12-03T16:26:52Z

Is this ready for merge?

I'm taking another look at testing to cover the coverage complaints. I'll let you know when I'm done.

Eliminate duplicated code with helper function

kirkmorrow · 2025-12-03T16:31:21Z

Okay... let's see how happy the AI bots are with these changes.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kirkmorrow · 2025-12-03T16:51:31Z

Darn it... I forgot to run "dart format" and made a second commit. However, it looks like the tests only ran on the first commit. @mtrezza can you force those tests to run again?

kirkmorrow · 2025-12-03T16:54:29Z

If those test pass on re-run then I'm ready to merge.

mtrezza · 2025-12-03T17:48:44Z

Re-running...

info • The import of 'package:connectivity_plus/connectivity_plus.dart' is unnecessary because all of the used elements are also provided by the import of 'package:connectivity_plus_platform_interface/connectivity_plus_platform_interface.dart' • packages/flutter/test/parse_connectivity_implementation_test.dart:3:8 • unnecessary_import

kirkmorrow · 2025-12-03T19:46:36Z

Looks like it's finally ready for merge.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# [flutter-v10.6.1](flutter-10.6.0...flutter-10.6.1) (2025-12-03) ### Bug Fixes * LiveQuery not working due to ethernet not recognized as connectivity state ([#1091](#1091)) ([60520d6](60520d6))

parseplatformorg · 2025-12-03T21:56:21Z

🎉 This change has been released in version flutter-v10.6.1

Use new ethernet enum

7a2cfc7

Part 2 of 2 fixes to address issue parse-community#1042

Copilot AI review requested due to automatic review settings December 2, 2025 15:46

Copilot started reviewing on behalf of kirkmorrow December 2, 2025 15:46 View session

kirkmorrow mentioned this pull request Dec 2, 2025

fix: Ethernet not recognized as connectivity state #1090

Merged

Copilot finished reviewing on behalf of kirkmorrow December 2, 2025 15:48

Copilot AI reviewed Dec 2, 2025

View reviewed changes

coderabbitai bot previously approved these changes Dec 2, 2025

View reviewed changes

mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Dec 2, 2025

parse-github-assistant bot removed the type:bug Impaired feature or lacking behavior that is likely assumed label Dec 2, 2025

Merge branch 'master' into use_ethernet_enum

644b051

mtrezza changed the title ~~Use new ethernet enum~~ fix: LiveQuery not working due to ethernet not recognized as connectivity state Dec 2, 2025

Update parse_server_sdk minimum level

83ffd5a

kirkmorrow dismissed coderabbitai[bot]’s stale review via 83ffd5a December 2, 2025 18:45

kirkmorrow requested a review from Copilot December 2, 2025 18:47

Copilot started reviewing on behalf of kirkmorrow December 2, 2025 18:48 View session

Copilot finished reviewing on behalf of kirkmorrow December 2, 2025 18:49

Copilot AI reviewed Dec 2, 2025

View reviewed changes

coderabbitai bot previously approved these changes Dec 2, 2025

View reviewed changes

Simple tests

80c45a4

kirkmorrow dismissed coderabbitai[bot]’s stale review via 80c45a4 December 2, 2025 18:56

kirkmorrow requested a review from Copilot December 2, 2025 18:56

Copilot started reviewing on behalf of kirkmorrow December 2, 2025 18:57 View session

Copilot finished reviewing on behalf of kirkmorrow December 2, 2025 18:58

Copilot AI reviewed Dec 2, 2025

View reviewed changes

Copilot finished reviewing on behalf of kirkmorrow December 3, 2025 15:36

Copilot AI reviewed Dec 3, 2025

View reviewed changes

coderabbitai bot previously approved these changes Dec 3, 2025

View reviewed changes

mtrezza previously approved these changes Dec 3, 2025

View reviewed changes

Improve testing

1edf729

Eliminate duplicated code with helper function

kirkmorrow dismissed stale reviews from mtrezza and coderabbitai[bot] via 1edf729 December 3, 2025 16:31

kirkmorrow requested a review from Copilot December 3, 2025 16:31

Copilot started reviewing on behalf of kirkmorrow December 3, 2025 16:31 View session

Copilot finished reviewing on behalf of kirkmorrow December 3, 2025 16:33

Run dart format to cleanup

f57af7b

Copilot AI reviewed Dec 3, 2025

View reviewed changes

coderabbitai bot previously approved these changes Dec 3, 2025

View reviewed changes

Remove unnecessary import

e8fe2d3

kirkmorrow dismissed coderabbitai[bot]’s stale review via e8fe2d3 December 3, 2025 19:41

coderabbitai bot approved these changes Dec 3, 2025

View reviewed changes

kirkmorrow requested a review from Copilot December 3, 2025 20:22

Copilot started reviewing on behalf of kirkmorrow December 3, 2025 20:23 View session

Copilot finished reviewing on behalf of kirkmorrow December 3, 2025 20:24

Copilot AI reviewed Dec 3, 2025

View reviewed changes

mtrezza merged commit 60520d6 into parse-community:master Dec 3, 2025
19 checks passed

parseplatformorg added the state:released label Dec 3, 2025

Uh oh!

fix: LiveQuery not working due to ethernet not recognized as connectivity state #1091

fix: LiveQuery not working due to ethernet not recognized as connectivity state #1091

Conversation

kirkmorrow commented Dec 2, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Issue

Approach

Tasks

Summary by CodeRabbit

Uh oh!

parse-github-assistant bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

parse-github-assistant bot commented Dec 2, 2025

Uh oh!

codecov bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mtrezza commented Dec 2, 2025

Uh oh!

kirkmorrow commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

kirkmorrow commented Dec 3, 2025

Uh oh!

kirkmorrow commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

kirkmorrow commented Dec 3, 2025

Uh oh!

kirkmorrow commented Dec 3, 2025

Uh oh!

mtrezza commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kirkmorrow commented Dec 3, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

parseplatformorg commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

kirkmorrow commented Dec 2, 2025 •

edited by coderabbitai bot

Loading

parse-github-assistant bot commented Dec 2, 2025 •

edited

Loading

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

codecov bot commented Dec 2, 2025 •

edited

Loading

mtrezza commented Dec 3, 2025 •

edited

Loading