Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

Pull Request

Issue

Closes: #2800

Approach

typescript-eslint 8.48.0 introduces stricter checking for @typescript-eslint/no-redundant-type-constituents. The FieldType union in types/tests.ts triggers this rule because any[] and Parse.Pointer are subtypes of object.

  • Added eslint-disable/enable comments around the FieldType union
  • The object type is intentionally included for testing Exclude<FieldType, object> functionality

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

dependabot bot and others added 2 commits November 28, 2025 17:30
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.47.0 to 8.48.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.48.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: typescript-eslint
  dependency-version: 8.48.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@coderabbitai
Copy link

coderabbitai bot commented Nov 28, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Nov 28, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/typescript-eslint-8.48.0 branch from 10e8d42 to 28592c1 Compare November 28, 2025 18:56
Copilot AI and others added 2 commits November 28, 2025 18:56
…ests.ts

Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
@mtrezza mtrezza marked this pull request as ready for review November 28, 2025 18:59
@mtrezza mtrezza changed the title [WIP] Refactor typescript-eslint from 8.47.0 to 8.48.0 refactor: Upgrade typescript-eslint from 8.47.0 to 8.48.0 Nov 28, 2025
@parse-github-assistant
Copy link

🚀 Thanks for opening this pull request!

Copy link
Contributor Author

Copilot AI commented Nov 28, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • googlechromelabs.github.io
    • Triggering command: /usr/local/bin/node node install.mjs (dns block)
  • https://api.github.com//advisories
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)
  • https://storage.googleapis.com/chrome-for-testing-public/142.0.7444.175/linux64/chrome-headless-shell-linux64.zip
    • Triggering command: /usr/local/bin/node node install.mjs (http block)
  • https://storage.googleapis.com/chrome-for-testing-public/142.0.7444.175/linux64/chrome-linux64.zip
    • Triggering command: /usr/local/bin/node node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title refactor: Upgrade typescript-eslint from 8.47.0 to 8.48.0 refactor: Bump typescript-eslint from 8.47.0 to 8.48.0 Nov 28, 2025
Copilot AI requested a review from mtrezza November 28, 2025 19:01
Copilot finished work on behalf of mtrezza November 28, 2025 19:01
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (59312a1) to head (fe635a7).
⚠️ Report is 3 commits behind head on dependabot/npm_and_yarn/typescript-eslint-8.48.0.

Additional details and impacted files
@@                                Coverage Diff                                @@
##           dependabot/npm_and_yarn/typescript-eslint-8.48.0    #2801   +/-   ##
=================================================================================
  Coverage                                             99.88%   99.88%           
=================================================================================
  Files                                                    64       64           
  Lines                                                  6220     6220           
  Branches                                               1488     1472   -16     
=================================================================================
  Hits                                                   6213     6213           
  Misses                                                    7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza merged commit 5e9cdc9 into dependabot/npm_and_yarn/typescript-eslint-8.48.0 Nov 30, 2025
26 of 29 checks passed
@mtrezza mtrezza deleted the copilot/sub-pr-2800 branch November 30, 2025 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants