Skip to content

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Dec 12, 2025

Pull Request

Issue

Closes: #2794

Approach

See #2802

Vite 7.x requires Node.js 20.19+ or 22.12+. The CI was failing because it tested against older Node versions.

Changes:

  • .github/workflows/ci.yml: Updated Node matrix to 20.19.0 and 22.12.0, removed Node 18 (no longer supported by vite 7)
  • .nvmrc: 20.15.0 → 20.19.0
  • package.json engines: "18 || 19 || 20 || 22"">=20.19.0 || >=22.12.0"

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Summary by CodeRabbit

  • Chores
    • Updated minimum Node.js version requirements to 20.19.0 or 22.12.0+. Earlier Node versions (18-19) are no longer supported.
    • Upgraded Vite build tool to version 7.2.4 for improved performance and latest features.

✏️ Tip: You can customize this high-level summary in your review settings.

dependabot bot and others added 3 commits November 28, 2025 17:30
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.4.1 to 7.2.4.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v7.2.4/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-version: 7.2.4
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 12, 2025

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Dec 12, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Dec 12, 2025

Warning

Rate limit exceeded

@mtrezza has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 28 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 607909f and c459962.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • .github/workflows/ci.yml (1 hunks)
  • package.json (2 hunks)
📝 Walkthrough

Walkthrough

The PR updates Node.js version requirements and dependencies. It removes support for Node 18 and 19, sets minimum versions to 20.19.0 and 22.12.0 across CI configuration and manifests, and upgrades Vite from 6.4.1 to 7.2.4. All version specifications are synchronized across configuration files.

Changes

Cohort / File(s) Change Summary
Node.js version standardization
.github/workflows/ci.yml, .nvmrc, package.json (engines field)
Removed Node 18 support, updated CI matrix to use Node 20.19.0 and 22.12.0, bumped .nvmrc to 20.19.0, and constrained package.json engines to >=20.19.0 || >=22.12.0
Dependency updates
package.json
Upgraded Vite from 6.4.1 to 7.2.4

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify Vite 7.2.4 compatibility with the project (check for breaking changes and necessary code adjustments)
  • Confirm all Node version specifications are consistent across configuration files

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main dependency upgrade (vite 6.4.1 to 7.2.4) but omits the significant secondary changes (Node.js version requirements and CI workflow updates).
Description check ✅ Passed The PR description follows the required template with all sections completed: Issue (linked to #2794), Approach (detailed explanation and change summary), and Tasks (marked as completed).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mtrezza mtrezza changed the title refactor: Bump vite from 6.4.1 to 7.2.4 Parse-SDK-JS refactor: Bump vite from 6.4.1 to 7.2.4 Dec 12, 2025
@mtrezza mtrezza added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Dec 12, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3986413 and 607909f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .github/workflows/ci.yml (1 hunks)
  • .nvmrc (1 hunks)
  • package.json (2 hunks)
🔇 Additional comments (2)
.nvmrc (1)

1-1: Node.js v20.19.0 is a legitimate release (March 13, 2025).

The .nvmrc pinning to 20.19.0 is sound. This version includes require(esm) enabled by default and module syntax detection improvements.

package.json (1)

87-90: Verify vite-plugin-commonjs@0.10.4 compatibility with Vite 7.2.4 before merging.

The config actively uses vite-plugin-commonjs in the build pipeline. Web search found no explicit compatibility statement for this plugin with Vite 7, which is ESM-only. While vite-plugin-node-polyfills@0.24.0 is confirmed compatible with Vite 7, the CommonJS plugin's behavior under Vite 7's ESM-only mode is unverified. Test the build thoroughly or confirm/upgrade to a Vite 7-compatible version.

This reverts commit 3d72cd9.
This reverts commit 7976d42.
This reverts commit 8fb8edb.
This reverts commit 8582efd.
coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 12, 2025
@mtrezza
Copy link
Member Author

mtrezza commented Dec 12, 2025

BREAKING CHANGE: This release increases the minimum required Node versions to 20.19.0, 22.12.0, and removes support for Node 18.x, 19.x.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.88%. Comparing base (3986413) to head (c459962).
⚠️ Report is 5 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #2829   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          64       64           
  Lines        6222     6222           
  Branches     1477     1489   +12     
=======================================
  Hits         6215     6215           
  Misses          7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza mtrezza merged commit edec316 into alpha Dec 12, 2025
13 checks passed
@mtrezza mtrezza deleted the copilot/sub-pr-2794 branch December 12, 2025 16:04
parseplatformorg pushed a commit that referenced this pull request Dec 12, 2025
# [8.0.0-alpha.1](7.1.3-alpha.1...8.0.0-alpha.1) (2025-12-12)

### Code Refactoring

* Bump vite from 6.4.1 to 7.2.4 ([#2829](#2829)) ([edec316](edec316))

### BREAKING CHANGES

* This release increases the minimum required Node versions to `20.19.0`, `22.12.0`, and removes support for Node `18.x`, `19.x`. ([edec316](edec316))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 12, 2025
parseplatformorg pushed a commit that referenced this pull request Dec 12, 2025
# [8.0.0](7.1.2...8.0.0) (2025-12-12)

### Bug Fixes

* Security upgrade jws ([#2822](#2822)) ([7d38c06](7d38c06))

### Code Refactoring

* Bump vite from 6.4.1 to 7.2.4 ([#2829](#2829)) ([edec316](edec316))

### BREAKING CHANGES

* This release increases the minimum required Node versions to `20.19.0`, `22.12.0`, and removes support for Node `18.x`, `19.x`. ([edec316](edec316))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants