-
-
Notifications
You must be signed in to change notification settings - Fork 600
refactor: Bump vite from 6.4.1 to 7.2.4 #2829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 6.4.1 to 7.2.4. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v7.2.4/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 7.2.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: mtrezza <5673677+mtrezza@users.noreply.github.com>
|
🚀 Thanks for opening this pull request! |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Warning Rate limit exceeded@mtrezza has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 28 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates Node.js version requirements and dependencies. It removes support for Node 18 and 19, sets minimum versions to 20.19.0 and 22.12.0 across CI configuration and manifests, and upgrades Vite from 6.4.1 to 7.2.4. All version specifications are synchronized across configuration files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
.github/workflows/ci.yml(1 hunks).nvmrc(1 hunks)package.json(2 hunks)
🔇 Additional comments (2)
.nvmrc (1)
1-1: Node.js v20.19.0 is a legitimate release (March 13, 2025).The .nvmrc pinning to 20.19.0 is sound. This version includes require(esm) enabled by default and module syntax detection improvements.
package.json (1)
87-90: Verify vite-plugin-commonjs@0.10.4 compatibility with Vite 7.2.4 before merging.The config actively uses
vite-plugin-commonjsin the build pipeline. Web search found no explicit compatibility statement for this plugin with Vite 7, which is ESM-only. Whilevite-plugin-node-polyfills@0.24.0is confirmed compatible with Vite 7, the CommonJS plugin's behavior under Vite 7's ESM-only mode is unverified. Test the build thoroughly or confirm/upgrade to a Vite 7-compatible version.
|
BREAKING CHANGE: This release increases the minimum required Node versions to |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #2829 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 64 64
Lines 6222 6222
Branches 1477 1489 +12
=======================================
Hits 6215 6215
Misses 7 7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# [8.0.0-alpha.1](7.1.3-alpha.1...8.0.0-alpha.1) (2025-12-12) ### Code Refactoring * Bump vite from 6.4.1 to 7.2.4 ([#2829](#2829)) ([edec316](edec316)) ### BREAKING CHANGES * This release increases the minimum required Node versions to `20.19.0`, `22.12.0`, and removes support for Node `18.x`, `19.x`. ([edec316](edec316))
|
🎉 This change has been released in version 8.0.0-alpha.1 |
# [8.0.0](7.1.2...8.0.0) (2025-12-12) ### Bug Fixes * Security upgrade jws ([#2822](#2822)) ([7d38c06](7d38c06)) ### Code Refactoring * Bump vite from 6.4.1 to 7.2.4 ([#2829](#2829)) ([edec316](edec316)) ### BREAKING CHANGES * This release increases the minimum required Node versions to `20.19.0`, `22.12.0`, and removes support for Node `18.x`, `19.x`. ([edec316](edec316))
|
🎉 This change has been released in version 8.0.0 |
Pull Request
Issue
Closes: #2794
Approach
See #2802
Vite 7.x requires Node.js 20.19+ or 22.12+. The CI was failing because it tested against older Node versions.
Changes:
.github/workflows/ci.yml: Updated Node matrix to 20.19.0 and 22.12.0, removed Node 18 (no longer supported by vite 7).nvmrc: 20.15.0 → 20.19.0package.jsonengines:"18 || 19 || 20 || 22"→">=20.19.0 || >=22.12.0"Tasks
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.