Skip to content

Conversation

@hallucinogen
Copy link
Contributor

Our internal integration tests was broken. This will fix it.

For the case of HttpClient, we can't do OnSuccess. If you take a look inside the code, we do special handling on error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I dislike this idea of doing it this way, because this requires that either:

  1. HostName ends with a /
  2. or relativeUri begins with a /

But never both. It works, I'm just afraid of something weird happening here as we move toward 'HostName' being more public.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works if both have /. I've tested this. But if none have /, it breaks.

The only issue I have with doing new Uri(ParseClient.HostName, relativeUri); is that

new Uri("https://api.parse.com/1/", "gogo");

translates into

https://api.parse.com/gogo

and not

https://api.parse.com/1/gogo

I'm open to better solution.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swore the issue was that

new Uri(new Uri("https://api.parse.com/1/"), "/gogo")

resulted in

https://api.parse.com/gogo

Unless I'm reading the Docs wrong...

As long as all of our relativeUris don't have leading slashes (which I thought I got rid of in #77), we should keep the path part of the HostName.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! Let me double-check and update this PR

@hallucinogen hallucinogen force-pushed the gogo.fix-integrations-tests branch from 7e6697f to 6fcc341 Compare December 17, 2015 04:24
hallucinogen added a commit that referenced this pull request Dec 17, 2015
@hallucinogen hallucinogen merged commit bcf2791 into master Dec 17, 2015
@hallucinogen hallucinogen deleted the gogo.fix-integrations-tests branch December 17, 2015 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants