Use the InvariantCulture to format DateTime. #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data["objectId"] = user.ObjectId; | ||
| if (user.CreatedAt != null) { | ||
| data["createdAt"] = user.CreatedAt.Value.ToString(ParseClient.DateFormatStrings.First()); | ||
| data["createdAt"] = user.CreatedAt.Value.ToString(ParseClient.DateFormatStrings.First(), |
Contributor
There was a problem hiding this comment.
Fix whitespace here...
Contributor
|
Looks good! Just fix up the whitespace, accept the CLA (hopefully the Facebook bot comes along sometime soon and pings it), and we should be good to go for merging. |
This allows dates in Arabic/Thai locales to be entered correctly in parse.
Contributor
Author
|
Thanks! Fixed the whitespace. There is another place where this bug needs to be fixed: in FacebookAuthenticationProvider.cs. However I could not find that code on github. Is that not open source? |
Contributor
richardjrossiii
added a commit
that referenced
this pull request
Feb 23, 2016
Use the InvariantCulture to format DateTime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dates in Arabic/Thai locales to be entered correctly in parse.