Use invariant device locale for number format conversion #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se.Test to access internal members
…(french, german or similar) using , instead of . as decimal separators. Closes issue parse-community#305
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 59.09% 58.77% -0.32%
==========================================
Files 91 91
Lines 6126 6128 +2
==========================================
- Hits 3620 3602 -18
- Misses 2506 2526 +20
Continue to review full report at Codecov.
|
…I instead of parse.com key as the parse service is shut down since early 2017
…gisterSubclass methods, which take a reference to Type and un-/ register it as parse subclass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds invariant culture to the conversion methods used in Parse.
It prevents conversion based on a device's locale (e.g. french or german) to error on numbers encoded with invariant/US locale (which uses . instead of , as decimal delimiter).
In addition a test method is added (to check this method on the developers machine locale)
The test might be extended to explicitly use non-invariant locales for testing (e.g. german or french) to allow it to properly work on machines not using those locales by default.
I'm not quite sure on what basis I should pick those locales to test again, except for those two I know of which caused the error described in issue #305. (Feedback is appreciated on this one)
This pull request handles issue #305