Skip to content

Conversation

@ryanmcdonough
Copy link
Contributor

Fix documentation regarding initializing the ParseClient

Fix documentation regarding initializing the ParseClient
Fix description of initialization.
@ryanmcdonough ryanmcdonough changed the title Update README.md Update documentation around initialization of ParseClient Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #330 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   56.48%   56.48%           
=======================================
  Files          91       91           
  Lines        6136     6136           
  Branches     1011     1011           
=======================================
  Hits         3466     3466           
  Misses       2490     2490           
  Partials      180      180           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afbcf97...5538e05. Read the comment docs.

@TobiasPott
Copy link
Member

Hi @ryanmcdonough
I've checked the pull request and your changes and appreciate your effort to add documentation to the code.
I've noticed that you've introduced a typo for the "ApplicationID" property. It's shows "ApplicationIx". Could you fix this and update/resubmit your pull request?

Fix typo on ApplicationId
@ryanmcdonough
Copy link
Contributor Author

Hey @TobiasPott thats sorted now.

@TobiasPott
Copy link
Member

Thank you very much @ryanmcdonough ,
another thing you may elaborate so I can understand the change is the change of the "Key" property to "WindowsKey". As the actual name of the property did not change I think it might be confusing using a different name in the Readme.md compared to the sources.
Sorry for being picky on a PR for documentation, though.

@ryanmcdonough
Copy link
Contributor Author

@TobiasPott - totally understand, so when I was using the package locally it's using WindowsKey however reviewing the code on github it's just Key - i'll revert my change on that

@TobiasPott
Copy link
Member

@ryanmcdonough Thank you very much. =)
I assume I'll get notified when you update this pull request and I'll proceed with merging it then.

Revert usage of WindowsKey to Key
@ryanmcdonough
Copy link
Contributor Author

All updated @TobiasPott :)

@TobiasPott TobiasPott merged commit daafde9 into parse-community:master Jun 12, 2020
@TobiasPott
Copy link
Member

Thank you very much @ryanmcdonough
Your pull request have been merged into the master branch.

I appreciate your contribution and your help. Feel free to continue to do so =).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants