Custom header support. #1250
Merged
Custom header support. #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
approved these changes
Jan 31, 2018
Contributor
flovilmart
left a comment
flovilmart
left a comment
There was a problem hiding this comment.
One small nit, otherwise it's awesome!
| clientKey:clientKey | ||
| bundle:bundle]; | ||
| if (configuration && [configuration.HTTPAdditionalHeaders count]) { | ||
| NSMutableDictionary *counpoundHeaders = [configuration.HTTPAdditionalHeaders mutableCopy]; |
Contributor
There was a problem hiding this comment.
perhaps rename to sessionConfigurationHeaders
flovilmart
reviewed
Jan 31, 2018
| clientKey:(nullable NSString *)clientKey { | ||
| NSURLSessionConfiguration *configuration = [NSURLSessionConfiguration defaultSessionConfiguration]; | ||
| NSURLSessionConfiguration *customConfiguration = Parse._currentManager.configuration.URLSessionConfiguration; | ||
| NSURLSessionConfiguration *configuration = customConfiguration ?: [NSURLSessionConfiguration defaultSessionConfiguration]; |
Contributor
There was a problem hiding this comment.
the URLSessionConfiguration should always be set on the configuration, so tghis way this is not required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.