Skip to content

Require clientKey for old SDK initialization API. #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2016
Merged

Require clientKey for old SDK initialization API. #847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Parse/Parse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ + (void)initialize {
///--------------------------------------

+ (void)setApplicationId:(NSString *)applicationId clientKey:(NSString *)clientKey {
PFParameterAssert(clientKey.length, @"`clientKey` should not be nil.");
currentParseConfiguration_.applicationId = applicationId;
currentParseConfiguration_.clientKey = clientKey;
currentParseConfiguration_.server = [PFInternalUtils parseServerURLString]; // TODO: (nlutsenko) Clean this up after tests are updated.
Expand Down
5 changes: 1 addition & 4 deletions Tests/Unit/ParseSetupUnitTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,7 @@ - (void)testInitializeWithNilApplicationIdShouldThrowException {
NSString *yolo = nil;
PFAssertThrowsInvalidArgumentException([Parse setApplicationId:yolo clientKey:yolo]);
PFAssertThrowsInvalidArgumentException([Parse setApplicationId:yolo clientKey:@"a"]);
}

- (void)testInitializeWithoutClientKeyNoThrow {
XCTAssertNoThrow([Parse setApplicationId:@"a" clientKey:nil]);
PFAssertThrowsInvalidArgumentException([Parse setApplicationId:@"a" clientKey:yolo]);
}

@end