Skip to content

Conversation

@cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Nov 30, 2021

New Pull Request Checklist

Issue Description

  • Linking a current user current has duplicate code.
  • When a test fails in the CI, it isn't retried to see if it will pass

Related issue: #n/a

Approach

  • Refactor linking of current user to reduce duplicate code.
  • Run failed tests multiple times to gather more information about reasons for failure

TODOs before merging

  • Add tests
  • Refactor URL mocker
  • Update CI for test failures

@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 30, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #292 (d1f1010) into main (4734212) will decrease coverage by 0.01%.
The diff coverage is 88.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
- Coverage   82.36%   82.34%   -0.02%     
==========================================
  Files         104      104              
  Lines       10659    10664       +5     
==========================================
+ Hits         8779     8781       +2     
- Misses       1880     1883       +3     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseUser.swift 79.77% <81.25%> (-0.34%) ⬇️
...Authentication/Protocols/ParseAuthentication.swift 72.16% <100.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4734212...d1f1010. Read the comment docs.

@cbaker6 cbaker6 merged commit fe67c88 into parse-community:main Nov 30, 2021
@cbaker6 cbaker6 deleted the linkingUser branch November 30, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant