-
-
Notifications
You must be signed in to change notification settings - Fork 132
Adds jazzy docs generation and gh-pages releases #137
Conversation
|
This looks okay at first glance here. I'm a bit short on time but I'm leaving my review still pending so I'll get to it later tonight when I can read into the travis.yml in detail. |
|
No problem! No rush! |
| - | | ||
| set -o pipefail | ||
| xcodebuild build -workspace ParseLiveQuery.xcworkspace -sdk macosx -scheme ParseLiveQuery-OSX -configuration Debug GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES GCC_GENERATE_TEST_COVERAGE_FILES=YES | xcpretty -c | ||
| after_success: bash <(curl -s https://codecov.io/bash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an identical after_success call above, but in a separate test stage for a separate environment. Is there a way to consolidate these two declarations of stage test with different scripts depending on the environment, but the same after_success result?
montymxb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright this looks good 👍 . The one nit is trivial and not really that important given in the overall scheme here. Something we can adjust later on (if we can that is).
|
I can have a look at consolidating the test steps later indeed |
|
My thoughts exactly 👍 . |
No description provided.