Skip to content

feat: Remember selected column when navigating between saved filters of a class with auto-load first row enabled #3028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2025
Merged

feat: Remember selected column when navigating between saved filters of a class with auto-load first row enabled #3028

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcb7a23
column fix
mtrezza Nov 28, 2025
eda385f
Merge branch 'alpha' into feat/keep-selected-column
mtrezza Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/dashboard/Data/Browser/DataBrowser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ export default class DataBrowser extends React.Component {
this.state = {
order: order,
current: null,
lastSelectedCol: 0,
editing: false,
copyableValue: undefined,
selectedObjectId: undefined,
Expand Down Expand Up @@ -197,6 +198,7 @@ export default class DataBrowser extends React.Component {
this.setState({
order: order,
current: null,
lastSelectedCol: 0,
editing: false,
simplifiedSchema: this.getSimplifiedSchema(props.schema, props.className),
allClassesSchema: this.getAllClassesSchema(props.schema, props.classes),
Expand Down Expand Up @@ -270,6 +272,12 @@ export default class DataBrowser extends React.Component {
}
}

if (this.state.current && this.state.current !== prevState.current) {
if (this.state.current.col !== this.state.lastSelectedCol) {
this.setState({ lastSelectedCol: this.state.current.col });
}
}

// Auto-load first row if enabled and conditions are met
if (
this.state.autoLoadFirstRow &&
Expand All @@ -285,7 +293,15 @@ export default class DataBrowser extends React.Component {
this.setShowAggregatedData(true);
this.setSelectedObjectId(firstRowObjectId);
// Also set the current cell to the first cell of the first row
this.setCurrent({ row: 0, col: 0 });
let col =
this.state.lastSelectedCol !== undefined &&
prevProps.className === this.props.className
? this.state.lastSelectedCol
: 0;
if (col >= this.state.order.length) {
col = 0;
}
this.setCurrent({ row: 0, col });
this.handleCallCloudFunction(
firstRowObjectId,
this.props.className,
Expand Down Expand Up @@ -437,7 +453,12 @@ export default class DataBrowser extends React.Component {
const firstRowObjectId = this.props.data[0].id;
this.setShowAggregatedData(true);
this.setSelectedObjectId(firstRowObjectId);
this.setCurrent({ row: 0, col: 0 });
let col =
this.state.lastSelectedCol !== undefined ? this.state.lastSelectedCol : 0;
if (col >= this.state.order.length) {
col = 0;
}
this.setCurrent({ row: 0, col });
this.handleCallCloudFunction(
firstRowObjectId,
this.props.className,
Expand Down
Loading