Skip to content

fix: Cell content not selected on double clicking data browser cell#3271

Merged
mtrezza merged 3 commits intoparse-community:alphafrom
mtrezza:fix/cell-not-selected-on-double-click
Mar 25, 2026
Merged

fix: Cell content not selected on double clicking data browser cell#3271
mtrezza merged 3 commits intoparse-community:alphafrom
mtrezza:fix/cell-not-selected-on-double-click

Conversation

@mtrezza
Copy link
Copy Markdown
Member

@mtrezza mtrezza commented Mar 25, 2026

Pull Request

Issue

Cell content not selected on double clicking data browser cell.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Summary by CodeRabbit

Release Notes

  • New Features
    • Number and string editor fields now automatically focus when opened.

@parse-github-assistant
Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement.

@parseplatformorg
Copy link
Copy Markdown
Contributor

parseplatformorg commented Mar 25, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 423e73c1-c085-452d-aac3-59b27125e575

📥 Commits

Reviewing files that changed from the base of the PR and between 298ae63 and 5780fd7.

📒 Files selected for processing (2)
  • src/components/NumberEditor/NumberEditor.react.js
  • src/components/StringEditor/StringEditor.react.js

📝 Walkthrough

Walkthrough

Two editor components (NumberEditor and StringEditor) now invoke autofocus behavior during mount, explicitly calling focus() on input/textarea refs before setting selection ranges to activate the editors immediately upon rendering.

Changes

Cohort / File(s) Summary
Editor Components Autofocus
src/components/NumberEditor/NumberEditor.react.js, src/components/StringEditor/StringEditor.react.js
Added this.inputRef.current.focus() call in componentDidMount() before selection range logic to enable immediate focus when editors mount.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is missing the 'Approach' section that details what changes were made to fix the issue, which is a required template section. Add an 'Approach' section describing how the autofocus fix was implemented in NumberEditor and StringEditor components.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding autofocus behavior to fix cell content selection on double-click in the data browser.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mtrezza mtrezza merged commit 9df3beb into parse-community:alpha Mar 25, 2026
8 of 10 checks passed
parseplatformorg pushed a commit that referenced this pull request Mar 25, 2026
# [9.1.0-alpha.11](9.1.0-alpha.10...9.1.0-alpha.11) (2026-03-25)

### Bug Fixes

* Cell content not selected on double clicking data browser cell ([#3271](#3271)) ([9df3beb](9df3beb))
@parseplatformorg
Copy link
Copy Markdown
Contributor

🎉 This change has been released in version 9.1.0-alpha.11

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Mar 25, 2026
@mtrezza mtrezza deleted the fix/cell-not-selected-on-double-click branch March 25, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants