Support mutable-content
#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like 1.7.8 isn't available on npmjs yet. |
Contributor
|
Yeah, we'll revisit when it will be available. Also, is it required? I see latest available version is 1.7.7 |
Contributor
Author
|
@flovilmart Yes, it's required as it adds a new property to the notification object. One of my PRs was merged and included in https://github.com/argon/node-apn/releases/tag/1.7.8 |
Contributor
|
@argon, seems that your release failed for 1.7.8, looks like your tags are usually vX.Y.Z maybe related ;) |
|
Oops, well spotted.I think I forgot to update the |
Contributor
|
@argon seems like it :) Thanks for your awesome job! |
|
Should be building now. |
Current coverage is 88.68% (diff: 100%)@@ master #27 diff @@
==========================================
Files 5 5
Lines 270 274 +4
Methods 30 30
Messages 0 0
Branches 46 47 +1
==========================================
+ Hits 239 243 +4
Misses 31 31
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In iOS 10, remote notification payloads can be mutated on the client before presentation to the user, allowing for rich content to be displayed (images, video).
The key to this is a mutable-content boolean value in the payload that must be set to 1.
I have added support for mutable-content, along with a test, and updated the
apndependency.Further information in the WWDC presentation (page 16): http://devstreaming.apple.com/videos/wwdc/2016/708tbh8wnspsg01hxwx/708/708_advanced_notifications.pdf