Support for rails 5.1.0 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@parse can we merge this? |
parse
requested changes
Aug 4, 2017
|
|
||
| initializer "rocket_pants.setup_caching" do |app| | ||
| if RocketPants.caching_enabled? | ||
| app.middleware.insert 'Rack::Runtime', RocketPants::CacheMiddleware |
There was a problem hiding this comment.
We need to maintain compatibility with rails 4, can you add a check for determining the rails version and use the old way for that?
There was a problem hiding this comment.
Can you change it to be:
if Rails::VERSION::MAJOR >= 5
|
@parse what about it now? |
parse
requested changes
Aug 4, 2017
|
|
||
| initializer "rocket_pants.setup_caching" do |app| | ||
| if RocketPants.caching_enabled? | ||
| app.middleware.insert 'Rack::Runtime', RocketPants::CacheMiddleware |
There was a problem hiding this comment.
Can you change it to be:
if Rails::VERSION::MAJOR >= 5
|
@parse ready! :) |
parse
approved these changes
Aug 4, 2017
|
I was going to squash all the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for rails 5.1.0.
Rails do not support anymore strings or symbols for middleware class names.