Skip to content

Support for rails 5.1.0 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 4, 2017
Merged

Support for rails 5.1.0 #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a2011e
Support for rails 5.1.0
MatayoshiMariano Aug 4, 2017
2f21e06
fixup! Support for rails 5.1.0
MatayoshiMariano Aug 4, 2017
8a69c37
fixup! Support for rails 5.1.0
MatayoshiMariano Aug 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/rocket_pants/railtie.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ class Railtie < Rails::Railtie

initializer "rocket_pants.setup_caching" do |app|
if RocketPants.caching_enabled?
app.middleware.insert 'Rack::Runtime', RocketPants::CacheMiddleware
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to maintain compatibility with rails 4, can you add a check for determining the rails version and use the old way for that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change it to be:
if Rails::VERSION::MAJOR >= 5

run_time_middleware = if Rails::VERSION::MAJOR >= 5
Rack::Runtime
else
"Rack::Runtime"
end
app.middleware.insert run_time_middleware, RocketPants::CacheMiddleware
end
end

Expand Down