fix: cross compile with GNU binutils 2.34

[de-sh]

Fixes CI failures on #1229

Description

---

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• New Features
  • Introduced support for cross-compilation on popular ARM64 and x86-64 Linux environments with verified Docker images ensuring secure and reliable builds.
  • Added new target configurations for aarch64-unknown-linux-gnu and x86_64-unknown-linux-gnu.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new configuration file, Cross.toml, has been introduced to define settings for cross-compilation targeting two architectures: aarch64-unknown-linux-gnu and x86_64-unknown-linux-gnu. Each target includes a specified Docker image along with its SHA256 digest for integrity verification. This configuration enables the build system to select and verify the appropriate Docker images for cross-compilation workflows.

Changes

File	Change Summary
Cross.toml	Added new target configurations for aarch64-unknown-linux-gnu and x86_64-unknown-linux-gnu, each specifying a Docker image with associated SHA256 digest.

Sequence Diagram(s)

sequenceDiagram
    participant D as Developer
    participant BS as Build System
    participant CT as Cross.toml
    participant DI as Docker Registry
    D->>BS: Request cross-compilation for a specific target
    BS->>CT: Read target configuration and image details
    CT-->>BS: Provide Docker image info and SHA256 digest
    BS->>DI: Pull Docker image using provided details
    DI-->>BS: Confirm image integrity
    BS->>D: Return compiled artifact

Loading

Poem

I'm a happy rabbit, hopping with delight,
New configs in Cross.toml shining oh so bright.
Two targets await with Docker images in view,
SHA256 keeps them secure and true.
With a bounce in my step and a twitch of my ear,
I celebrate these changes with a joyful cheer!
🥕🐰

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

Cross.toml (2)

1-3: Validate aarch64 Target Configuration and Documentation

The configuration for the aarch64-unknown-linux-gnu target is correctly defined with a Docker image and its associated SHA256 digest. To improve maintainability, please consider adding a brief comment explaining the rationale behind the selected Docker image and its role in ensuring compatibility with GNU binutils 2.34. This will aid future maintainers in understanding the context for these settings.

---

4-6: Verify x86_64 Target Consistency and Image Digest

The entry for the x86_64-unknown-linux-gnu target is set up similarly to the aarch64 target using an identical Docker image digest. Please double-check that this shared digest is appropriate for both target platforms. Additionally, consider adding an inline comment to indicate if both targets truly share the same image or if there are subtle differences, ensuring clarity for future reviews.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 824f642 and c7f236d.

📒 Files selected for processing (1)

• Cross.toml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Build Default x86_64-apple-darwin
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: coverage