-
-
Notifications
You must be signed in to change notification settings - Fork 157
chore: update docker builds to self hosted runner #1488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update docker builds to self hosted runner #1488
Conversation
updates to - 1. edge 2. edge debug 3. edge kafka 4. release also added cleanup step in all workflows
WalkthroughFour GitHub Actions workflows changed their runner from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/build-push-edge.yaml (1)
40-41: Reconsider aggressive cache pruning.Same concern as build-push-edge-debug.yaml: pruning all cache before every build eliminates layer reuse and increases build times. Consider time-based or size-based pruning strategies instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/build-push-edge-debug.yaml(2 hunks).github/workflows/build-push-edge-kafka.yaml(2 hunks).github/workflows/build-push-edge.yaml(1 hunks).github/workflows/release.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: coverage
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
🔇 Additional comments (3)
.github/workflows/build-push-edge.yaml (1)
15-15: Verify self-hosted runner prerequisites.Same considerations as build-push-edge-debug.yaml regarding self-hosted runner setup, security, and workspace cleanup.
.github/workflows/build-push-edge-kafka.yaml (1)
15-15: Verify self-hosted runner prerequisites.Same considerations as other workflows regarding self-hosted runner setup, security, and workspace cleanup.
.github/workflows/release.yml (1)
351-351: Verify self-hosted runner prerequisites.Only the docker build job uses self-hosted runners while other jobs (build-linux, build-windows, build-mac, etc.) remain on GitHub-hosted runners. Ensure the self-hosted runner has all necessary Docker tools and follows the same security considerations noted for other workflows.
updates to -
also added cleanup step in all workflows
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.