Skip to content

Conversation

@nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Dec 16, 2025

updates to -

  1. edge
  2. edge debug
  3. edge kafka
  4. release

also added cleanup step in all workflows

Summary by CodeRabbit

  • Chores
    • CI/CD workflows updated to run build and release jobs on self-hosted runners for more consistent performance.
    • Added an automated Docker builder cache cleanup step (docker builder prune -f) after metadata extraction to free disk space and improve subsequent build efficiency.

✏️ Tip: You can customize this high-level summary in your review settings.

updates to -
1. edge
2. edge debug
3. edge kafka
4. release

also added cleanup step in all workflows
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

Walkthrough

Four GitHub Actions workflows changed their runner from ubuntu-latest to self-hosted; three workflows also add a "Clean up builder cache" step executing docker builder prune -f after metadata extraction.

Changes

Cohort / File(s) Summary
Docker build workflows with cache cleanup
​.github/workflows/build-push-edge-debug.yaml, ​.github/workflows/build-push-edge-kafka.yaml, ​.github/workflows/release.yml
Runner changed from ubuntu-latest to self-hosted; added a "Clean up builder cache" step running docker builder prune -f after metadata extraction.
Docker build workflow runner update
​.github/workflows/build-push-edge.yaml
Runner changed from ubuntu-latest to self-hosted (no cache-prune step added).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify self-hosted runner labels and availability referenced by each workflow.
  • Confirm docker builder prune -f placement and intended scope/permissions for self-hosted runners.
  • Ensure any required runner permissions/secrets are configured and spacing/indentation in YAML is consistent.

Possibly related PRs

Suggested reviewers

  • nitisht

Poem

🐰 I hopped through workflows, neat and quick,

Swapped runners over—quite the trick.
A tidy prune to clear the way,
Builders hum and files obey. ✨🧺

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is minimal but captures the key changes. However, it lacks detail on rationale, testing confirmation, and documentation updates required by the template. Expand the description to explain why self-hosted runners are needed, confirm testing was performed, and clarify if documentation updates are needed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating Docker builds to use self-hosted runners instead of ubuntu-latest across multiple workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1653f22 and ae9cf2e.

📒 Files selected for processing (1)
  • .github/workflows/build-push-edge-kafka.yaml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build-push-edge-kafka.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Kafka aarch64-apple-darwin
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: coverage
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/build-push-edge.yaml (1)

40-41: Reconsider aggressive cache pruning.

Same concern as build-push-edge-debug.yaml: pruning all cache before every build eliminates layer reuse and increases build times. Consider time-based or size-based pruning strategies instead.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c68c3f and 4ae8ef0.

📒 Files selected for processing (4)
  • .github/workflows/build-push-edge-debug.yaml (2 hunks)
  • .github/workflows/build-push-edge-kafka.yaml (2 hunks)
  • .github/workflows/build-push-edge.yaml (1 hunks)
  • .github/workflows/release.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: coverage
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: Build Kafka aarch64-apple-darwin
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
🔇 Additional comments (3)
.github/workflows/build-push-edge.yaml (1)

15-15: Verify self-hosted runner prerequisites.

Same considerations as build-push-edge-debug.yaml regarding self-hosted runner setup, security, and workspace cleanup.

.github/workflows/build-push-edge-kafka.yaml (1)

15-15: Verify self-hosted runner prerequisites.

Same considerations as other workflows regarding self-hosted runner setup, security, and workspace cleanup.

.github/workflows/release.yml (1)

351-351: Verify self-hosted runner prerequisites.

Only the docker build job uses self-hosted runners while other jobs (build-linux, build-windows, build-mac, etc.) remain on GitHub-hosted runners. Ensure the self-hosted runner has all necessary Docker tools and follows the same security considerations noted for other workflows.

@nitisht nitisht merged commit 25a04d8 into parseablehq:main Dec 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants