Fix 1458: Helm template bug: logstream

[AdheipSingh]

Fixes #1458.

Description

---

This PR has:

• been tested to ensure log ingestion and log query works.
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added documentation for new or modified features or behaviors.

Summary by CodeRabbit

• Chores
  • Updated local mode secret configuration structure in deployment templates.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

The Helm template for the logstream job has been updated to iterate over .Values.parseable.localModeSecret.secrets instead of .Values.parseable.localModeSecret when generating environment variables from local secrets. The nested key iteration logic remains unchanged.

Changes

Cohort / File(s)	Summary
Helm Template Configuration helm/templates/logstream-job.yaml	Updated the local mode secret iteration source from .Values.parseable.localModeSecret to .Values.parseable.localModeSecret.secrets to correctly reference the nested secrets field when generating environment variables.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

• Verify the change aligns with the expected YAML structure for local mode secrets in the values file
• Confirm this mirrors the pattern used for s3ModeSecret (as referenced in related PR #1434)

Possibly related PRs

• Add missing key 'secret' to logstream-job helm template. #1434: Applies an identical fix pattern to the s3ModeSecret field in the same Helm template, suggesting a systematic correction to how secrets are iterated over.

Suggested reviewers

• nitisht

Poem

🐰 A little hop through YAML so neat,
Where secrets find their nested seat,
We fixed the path, now iterations flow,
Environment variables steal the show! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The PR description references issue #1458 but lacks substantive details about the bug, solution, and key changes made to the Helm template.	Provide a detailed description explaining what the logstream Helm template bug is, why the change from iterating over .Values.parseable.localModeSecret.secrets (instead of .Values.parseable.localModeSecret) fixes it, and confirm testing was completed.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: fixing a Helm template bug in the logstream configuration by correcting how local secrets are iterated.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}