Skip to content

skip internal stream hottier for suspended tenant#1606

Merged
nikhilsinhaparseable merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:hottier-suspended-ws
Apr 1, 2026
Merged

skip internal stream hottier for suspended tenant#1606
nikhilsinhaparseable merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:hottier-suspended-ws

Conversation

@nikhilsinhaparseable
Copy link
Copy Markdown
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Apr 1, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed hot-tier metadata provisioning to properly exclude suspended workspaces from background operations.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 07b1b06e-f116-4e66-a5dd-d905c9978d64

📥 Commits

Reviewing files that changed from the base of the PR and between f761b2d and ce57818.

📒 Files selected for processing (2)
  • src/hottier.rs
  • src/tenants/mod.rs

Walkthrough

The changes add suspension checks to hot-tier operations. A new is_workspace_suspended method is introduced in TenantMetadata to detect suspended workspaces. This method is then integrated into put_internal_stream_hot_tier and create_pstats_hot_tier to prevent hot-tier provisioning for suspended tenants.

Changes

Cohort / File(s) Summary
Tenant Metadata
src/tenants/mod.rs
Added public method is_workspace_suspended(&self, tenant_id: &str) -> bool to check if a tenant's workspace service is in the suspended services set.
Hot Tier Manager
src/hottier.rs
Added dependency on tenants::TENANT_METADATA. Integrated suspension checks in put_internal_stream_hot_tier and create_pstats_hot_tier to skip hot-tier operations for tenants with suspended workspaces.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 Hop, hop, suspended tenants fade,
No hot-tier paths shall now be made,
With is_workspace_suspended check so keen,
Cleanest hot-tier flows ever seen! 🔥

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is empty, missing all required sections including description of goals, rationale, key changes, and testing/documentation checkboxes. Add a comprehensive description explaining the purpose of skipping hot-tier operations for suspended tenants, the rationale, key changes made, and complete the testing and documentation checklist.
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: skipping hot-tier operations for suspended tenants in internal stream handling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@nikhilsinhaparseable nikhilsinhaparseable merged commit 6802f7c into parseablehq:main Apr 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants