Skip to content

update flight port in node metadata#1623

Merged
nikhilsinhaparseable merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:fix-flight-port
Apr 16, 2026
Merged

update flight port in node metadata#1623
nikhilsinhaparseable merged 1 commit intoparseablehq:mainfrom
nikhilsinhaparseable:fix-flight-port

Conversation

@nikhilsinhaparseable
Copy link
Copy Markdown
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Apr 16, 2026

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Flight port configuration changes are now properly detected, logged, and synchronized with system metadata.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c4e084fb-ccfc-43c4-985d-a54a594364d9

📥 Commits

Reviewing files that changed from the base of the PR and between 6dcf7bb and 9da2f21.

📒 Files selected for processing (1)
  • src/handlers/http/modal/mod.rs

Walkthrough

The NodeMetadata::update_metadata function now reconciles the flight_port from configuration options with stored metadata. When the ports differ, it logs an info message and updates the metadata value accordingly.

Changes

Cohort / File(s) Summary
Flight Port Metadata Reconciliation
src/handlers/http/modal/mod.rs
Added flight port comparison and update logic to NodeMetadata::update_metadata. Converts options.flight_port to String, checks for differences from current metadata, logs an informational message when updated, and synchronizes the value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A port took flight, once hidden from sight,
But now we compare and log it right,
When options align with metadata's dream,
The flight port flows in a synchronized stream! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided. The repository template requires a description section with goals, rationale, and key changes. Add a detailed pull request description following the template, including the issue number (if applicable), goal description, rationale for changes, and key changes made.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating flight port in node metadata, which aligns with the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@nikhilsinhaparseable nikhilsinhaparseable merged commit 6191c36 into parseablehq:main Apr 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants