Skip to content

update help with shortcuts#106

Merged
nitisht merged 3 commits into
mainfrom
cleanup
Jun 6, 2026
Merged

update help with shortcuts#106
nitisht merged 3 commits into
mainfrom
cleanup

Conversation

@nitisht
Copy link
Copy Markdown
Member

@nitisht nitisht commented Jun 6, 2026

Summary by CodeRabbit

  • New Features

    • Dataset list now shows dataset type and last-ingested timestamp alongside names
    • SQL sidebar dataset header now includes a Ctrl‑D shortcut hint
  • Improvements

    • CLI help now consistently advertises common aliases (e.g., "remove|rm", "list|ls") for user, profile, role, and dataset commands

@nitisht nitisht requested a review from pratik50 June 6, 2026 12:47
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 6, 2026

Review Change Stack

Warning

Review limit reached

@nitisht, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 39 minutes and 50 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 225c8a46-4a11-4e49-b14b-d0ad78c7ed03

📥 Commits

Reviewing files that changed from the base of the PR and between 8d73a7b and e6ebad0.

📒 Files selected for processing (1)
  • cmd/dataset.go
📝 Walkthrough

Walkthrough

The PR updates CLI usage strings to display alias forms (remove|rm, list|ls), enriches dataset list items with Type and LastIngested and passes dataset.DatasetType into rendering, and adds a <ctrl-d> hint to the SQL UI dataset header.

Changes

CLI Documentation and Dataset Rendering Enhancement

Layer / File(s) Summary
Dataset list model and rendering enrichment
cmd/dataset.go
DatasetListItem gains Type and LastIngested; Render() conditionally appends Type; dataset list command sets DatasetListItem.Type from dataset.DatasetType.
CLI command usage documentation alignment
cmd/dataset.go, cmd/profile.go, cmd/queryList.go, cmd/role.go, cmd/user.go
Use strings updated to show pipe-separated aliases (`remove
SQL UI dataset shortcut indicator
pkg/model/query.go
Dataset header in SQL sidebar controls box now displays the <ctrl-d> keyboard shortcut hint.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • parseablehq/pb#100: Overlaps with dataset-type-aware rendering changes and similar CLI usage/alias documentation updates.

Poem

🐰 Hoppity hops through code tonight,

rm and ls now shine in light,
Types and times beside each name,
Shortcuts wink — the UI's game,
A little rabbit cheers, delight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'update help with shortcuts' directly describes the main changes across all files, which consistently add keyboard shortcut documentation (list|ls, remove|rm, ctrl-d) to CLI command usage strings.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
cmd/dataset.go (1)

58-58: ⚡ Quick win

Remove unused LastIngested field.

The LastIngested field is declared but never assigned or referenced anywhere in the codebase. This is dead code.

♻️ Proposed fix
 type DatasetListItem struct {
 	Name string
 	Type string
-	LastIngested time.Time
 }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cmd/dataset.go` at line 58, Remove the unused LastIngested field from the
struct where it is declared (remove the line "LastIngested time.Time") since it
is never assigned or referenced; update any related struct tags, constructors,
marshaling/unmarshaling code, and tests that might assume the field no longer
exists, then run the build and tests to ensure nothing else expects
LastIngested.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmd/dataset.go`:
- Around line 64-65: The render always outputs brackets because
ItemOuter.Render(fmt.Sprintf("%s %s [%s]", bullet, name, datasetType))
unconditionally includes the type; change this to omit the " [type]" fragment
when item.Type (or datasetType) is empty—e.g., compute the display string
conditionally before calling ItemOuter.Render by checking item.Type/ datasetType
and using fmt.Sprintf("%s %s [%s]", ...) only when non-empty, otherwise use
fmt.Sprintf("%s %s", bullet, name); keep references to
StandardStyle.Render(datasetType) and ItemOuter.Render intact.

---

Nitpick comments:
In `@cmd/dataset.go`:
- Line 58: Remove the unused LastIngested field from the struct where it is
declared (remove the line "LastIngested time.Time") since it is never assigned
or referenced; update any related struct tags, constructors,
marshaling/unmarshaling code, and tests that might assume the field no longer
exists, then run the build and tests to ensure nothing else expects
LastIngested.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 59832504-60da-4f72-87d0-e078c5b2f9f4

📥 Commits

Reviewing files that changed from the base of the PR and between 88fe922 and 26b6558.

📒 Files selected for processing (6)
  • cmd/dataset.go
  • cmd/profile.go
  • cmd/queryList.go
  • cmd/role.go
  • cmd/user.go
  • pkg/model/query.go

Comment thread cmd/dataset.go
@pratik50
Copy link
Copy Markdown
Contributor

pratik50 commented Jun 6, 2026

PR looks good to me!

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2026

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


1 out of 2 committers have signed the CLA.
@nitisht
@copilot
You can retrigger this bot by commenting recheck in this Pull Request

@nitisht nitisht merged commit 706d987 into main Jun 6, 2026
3 of 4 checks passed
@nitisht nitisht deleted the cleanup branch June 6, 2026 18:54
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants