Conversation
|
Warning Review limit reached
More reviews will be available in 39 minutes and 50 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. 📝 WalkthroughWalkthroughThe PR updates CLI usage strings to display alias forms (remove|rm, list|ls), enriches dataset list items with Type and LastIngested and passes dataset.DatasetType into rendering, and adds a ChangesCLI Documentation and Dataset Rendering Enhancement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
cmd/dataset.go (1)
58-58: ⚡ Quick winRemove unused
LastIngestedfield.The
LastIngestedfield is declared but never assigned or referenced anywhere in the codebase. This is dead code.♻️ Proposed fix
type DatasetListItem struct { Name string Type string - LastIngested time.Time }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmd/dataset.go` at line 58, Remove the unused LastIngested field from the struct where it is declared (remove the line "LastIngested time.Time") since it is never assigned or referenced; update any related struct tags, constructors, marshaling/unmarshaling code, and tests that might assume the field no longer exists, then run the build and tests to ensure nothing else expects LastIngested.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/dataset.go`:
- Around line 64-65: The render always outputs brackets because
ItemOuter.Render(fmt.Sprintf("%s %s [%s]", bullet, name, datasetType))
unconditionally includes the type; change this to omit the " [type]" fragment
when item.Type (or datasetType) is empty—e.g., compute the display string
conditionally before calling ItemOuter.Render by checking item.Type/ datasetType
and using fmt.Sprintf("%s %s [%s]", ...) only when non-empty, otherwise use
fmt.Sprintf("%s %s", bullet, name); keep references to
StandardStyle.Render(datasetType) and ItemOuter.Render intact.
---
Nitpick comments:
In `@cmd/dataset.go`:
- Line 58: Remove the unused LastIngested field from the struct where it is
declared (remove the line "LastIngested time.Time") since it is never assigned
or referenced; update any related struct tags, constructors,
marshaling/unmarshaling code, and tests that might assume the field no longer
exists, then run the build and tests to ensure nothing else expects
LastIngested.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 59832504-60da-4f72-87d0-e078c5b2f9f4
📒 Files selected for processing (6)
cmd/dataset.gocmd/profile.gocmd/queryList.gocmd/role.gocmd/user.gopkg/model/query.go
|
PR looks good to me! |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
Summary by CodeRabbit
New Features
Improvements