fix: Add default values to uninitialized typed properties in Response class#81
Merged
GeraudBourdin merged 1 commit intopartITech:mainfrom Feb 5, 2026
Conversation
… class Properties like $created, $model, $fingerPrint, and $pages were declared without defaults, causing 'must not be accessed before initialization' errors when accessing fields not present in certain API response types (e.g. $pages is only in OCR responses, $created is not in OCR responses). Fixes partITech#80
Collaborator
|
Thanks a lot ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properties like
$created,$model,$fingerPrint, and$pageswere declared without defaults, causing "must not be accessed before initialization" errors when accessing fields not present in certain API response types.For example:
$pagesis only in OCR responses → errors on chat$createdis not in OCR responses → errors on OCRFixes #80