-
Notifications
You must be signed in to change notification settings - Fork 523
Clear WLAN WD so it does not interfere with Particle.connect() #2016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
06b9e42
Clear WLAN WD in disconnect() so that it does not interfere with Part…
keeramis f4c4427
Adding documentation for the test cs
keeramis 8125c31
Clear g_state_conn_attempt in the test, fix conditional, fix older co…
keeramis 23a0b3d
Fix incompatible type between true and 1
keeramis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| #include "application.h" | ||
| #include "unit-test/unit-test.h" | ||
|
|
||
| // make clean all TEST=wiring/no_fixture PLATFORM=electron -s COMPILE_LTO=n program-dfu DEBUG_BUILD=y | ||
| // make clean all TEST=wiring/no_fixture PLATFORM=electron -s COMPILE_LTO=n program-dfu DEBUG_BUILD=y USE_THREADING=y | ||
| // | ||
| // Serial1LogHandler logHandler(115200, LOG_LEVEL_ALL, { | ||
| // { "comm", LOG_LEVEL_NONE }, // filter out comm messages | ||
| // { "system", LOG_LEVEL_INFO } // only info level for system messages | ||
| // }); | ||
|
|
||
| UNIT_TEST_APP(); | ||
|
|
||
| SYSTEM_THREAD(ENABLED); | ||
52 changes: 52 additions & 0 deletions
52
user/tests/wiring/cell_connect_after_off/cellular_conn_after_off.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Copyright (c) 2018 Particle Industries, Inc. All rights reserved. | ||
| * | ||
| * This library is free software; you can redistribute it and/or | ||
| * modify it under the terms of the GNU Lesser General Public | ||
| * License as published by the Free Software Foundation, either | ||
| * version 3 of the License, or (at your option) any later version. | ||
| * | ||
| * This library is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| * Lesser General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU Lesser General Public | ||
| * License along with this library; if not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #include "application.h" | ||
| #include "unit-test/unit-test.h" | ||
|
|
||
| #if Wiring_Cellular == 1 | ||
|
|
||
| // Global variable to indicate a connection attempt | ||
| volatile int g_state_conn_attempt = 0; | ||
|
|
||
| static void nwstatus_callback_handler(system_event_t ev, int param) { | ||
| if (param == network_status_connecting){ | ||
| g_state_conn_attempt = 1; | ||
| } | ||
| } | ||
|
|
||
| test(CELLULAR_CONN_01_conn_after_off) | ||
| { | ||
| // Connect to Particle cloud | ||
| Particle.connect(); | ||
| delay(30000); | ||
| // Power off the cell radio | ||
| Cellular.off(); | ||
| delay(60000); | ||
| // Callback handler for network_status | ||
| System.on(network_status, nwstatus_callback_handler); | ||
| // clear g_state_conn_attempt just-in-case | ||
| g_state_conn_attempt = 0; | ||
| // Check that Particle.connect() attempts to work after the delay | ||
|
||
| Particle.connect(); | ||
| // Wait sometime for Particle.connect() to try | ||
| delay(30000); | ||
| // Verify that a connection attempt has been made | ||
| assertEqual(g_state_conn_attempt, 1); | ||
| } | ||
|
|
||
| #endif // Wiring_Cellular == 1 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| The following illustrates the problem statement: | ||
| > Keep antenna disconnected for this test | ||
| 1. With antenna disconnected, run `Particle.connect()` | ||
| 2. Run `Cellular.off()` | ||
| 3. After 60 sec, run `Particle.connect()` again, and verify that you see cellular AT traffic to turn on the modem or connect to the network. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a README with prerequisites for running this test. AFAIK it's required to detach the antenna.