Skip to content

Conversation

@monkbroc
Copy link
Member

@monkbroc monkbroc commented Jan 11, 2022

According to https://github.blog/2021-09-01-improving-git-protocol-security-github/, having a dependency git://github.com/particle-iot/metalsmith-autotoc isn't supported anymore. I updated them to github:particle-iot/metalsmith-autotoc which will use HTTPS or SSH depending on the local git config.

I checked the package-lock.json and the git commit hashes for the updated packages haven't changed.

I also updated the status badge to link to CircleCI and checked that this page is publicly accessible in incognito mode.

@monkbroc monkbroc requested a review from rickkas7 January 11, 2022 21:44
Copy link
Contributor

@rickkas7 rickkas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@monkbroc monkbroc merged commit 1f44c5c into master Jan 11, 2022
@monkbroc monkbroc deleted the bug/sc-95133/npm-ci-fails-on-docs branch January 11, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants