Bug: `partysocket` does not return `data` object (as similar to original library it was forked from)

[titanism]

Besides #537 there is another core breaking bug that disables us from using partysocket.

The issue is that when used with websocket-as-promised, unlike the original fork of reconnecting-websocket at https://github.com/pladaria/reconnecting-websocket, the extractMessageData(event) function of websocket-as-promised does not receive the event.data property.

This is due to an underlying and breaking change (we consider this a bug) in partysocket.

If you make a test project and const response = await wsp.sendRequest({ some: 'thing' }); you will see that the returned data (if you call ws.send(...) with the exact same payload from the server back to the client on this message being received – it will not return event.data in extractMessageData option function per the docs at https://github.com/vitalets/websocket-as-promised#usage-with-ws

[titanism]

Note that as soon as you swap out partysocket with reconnectingwebsocket, the issue goes away and extractMessageData works perfectly fine.

[threepointone]

Thanks for reporting! I'll have a look

[threepointone]

It's not clear to me that extractMessageData should receive event.data, I'm now of the opinion it should receive event itself, so as to be consistent across runtimes. ParrySocket's WebSocket implementation isn't meant to be a clone of the WS module, but a 'standard' WebSocket. I'm going to close this, but I'm happy to discuss.