refactor(hir): intern subroutine ids#11
Merged
roife merged 76 commits intoApr 14, 2026
Merged
Conversation
hongjr03
force-pushed
the
refactor/consolidate-subroutine-container-id
branch
from
fd011e0 to
ac8323a
Compare
hongjr03
changed the title
# Conflicts: # crates/slang
…clarator names - Add `in_decl_name` field to CompletionContext to detect when cursor is at a new symbol name position (e.g., after type in port declaration) - Fix line comment detection when comment appears before preprocessor directives like `timescale - now checks nested trivia inside directive - Change trivia_at_offset to return TriviaKind instead of SyntaxTrivia to avoid lifetime issues with nested trivia - Add comprehensive tests for line comment detection in various positions
…letion
- Distinguish between value names and subroutine names in completion
- Generate snippet with placeholder for subroutine calls: func(${1:args})
feat(ide): completion
feat: add diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, subroutines had split representations depending on whether they were declared in a module or at file scope (and callers needed to branch on that). Now subroutines are represented by a single
SubroutineIdthat can be lookup’d to recover itsSubroutineLoc { cont_id, src }, eliminating the need for a separateSubroutineLocation-style discriminator.